Skip to content

Commit 58ccdba

Browse files
committed
Remove mistaken changes to unittests.
Artifacts of an earlier attempt at this. :(
1 parent 5aa7cac commit 58ccdba

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

Firestore/Example/Tests/Core/FSTQueryListenerTests.m

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,7 @@ - (void)testDoesNotRaiseEventsForMetadataChangesUnlessSpecified {
173173
FSTListenOptions *options =
174174
[[FSTListenOptions alloc] initWithIncludeQueryMetadataChanges:YES
175175
includeDocumentMetadataChanges:NO
176-
waitForSyncWhenOnline:NO
177-
getOptions:[FIRGetOptions defaultOptions]];
176+
waitForSyncWhenOnline:NO];
178177

179178
FSTQueryListener *filteredListener =
180179
[self listenToQuery:query accumulatingSnapshots:filteredAccum];
@@ -215,8 +214,7 @@ - (void)testRaisesDocumentMetadataEventsOnlyWhenSpecified {
215214
FSTListenOptions *options =
216215
[[FSTListenOptions alloc] initWithIncludeQueryMetadataChanges:NO
217216
includeDocumentMetadataChanges:YES
218-
waitForSyncWhenOnline:NO
219-
getOptions:[FIRGetOptions defaultOptions]];
217+
waitForSyncWhenOnline:NO];
220218

221219
FSTQueryListener *filteredListener =
222220
[self listenToQuery:query accumulatingSnapshots:filteredAccum];
@@ -267,8 +265,7 @@ - (void)testRaisesQueryMetadataEventsOnlyWhenHasPendingWritesOnTheQueryChanges {
267265
FSTListenOptions *options =
268266
[[FSTListenOptions alloc] initWithIncludeQueryMetadataChanges:YES
269267
includeDocumentMetadataChanges:NO
270-
waitForSyncWhenOnline:NO
271-
getOptions:[FIRGetOptions defaultOptions]];
268+
waitForSyncWhenOnline:NO];
272269

273270
FSTQueryListener *fullListener =
274271
[self listenToQuery:query options:options accumulatingSnapshots:fullAccum];
@@ -337,8 +334,7 @@ - (void)testWillWaitForSyncIfOnline {
337334
options:[[FSTListenOptions alloc]
338335
initWithIncludeQueryMetadataChanges:NO
339336
includeDocumentMetadataChanges:NO
340-
waitForSyncWhenOnline:YES
341-
getOptions:[FIRGetOptions defaultOptions]]
337+
waitForSyncWhenOnline:YES]
342338

343339
accumulatingSnapshots:events];
344340

@@ -383,8 +379,7 @@ - (void)testWillRaiseInitialEventWhenGoingOffline {
383379
options:[[FSTListenOptions alloc]
384380
initWithIncludeQueryMetadataChanges:NO
385381
includeDocumentMetadataChanges:NO
386-
waitForSyncWhenOnline:YES
387-
getOptions:[FIRGetOptions defaultOptions]]
382+
waitForSyncWhenOnline:YES]
388383

389384
accumulatingSnapshots:events];
390385

Firestore/Example/Tests/SpecTests/FSTSyncEngineTestDriver.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,7 @@ - (FSTTargetID)addUserListenerWithQuery:(FSTQuery *)query {
244244
FSTListenOptions *options =
245245
[[FSTListenOptions alloc] initWithIncludeQueryMetadataChanges:YES
246246
includeDocumentMetadataChanges:YES
247-
waitForSyncWhenOnline:NO
248-
getOptions:[FIRGetOptions defaultOptions]];
247+
waitForSyncWhenOnline:NO];
249248

250249
FSTQueryListener *listener = [[FSTQueryListener alloc]
251250
initWithQuery:query

0 commit comments

Comments
 (0)