File tree 2 files changed +5
-3
lines changed 2 files changed +5
-3
lines changed Original file line number Diff line number Diff line change @@ -278,7 +278,7 @@ - (void)deleteDocumentRef:(FIRDocumentReference *)ref {
278
278
279
279
- (void )mergeDocumentRef : (FIRDocumentReference *)ref data : (NSDictionary <NSString *, id> *)data {
280
280
[ref setData: data
281
- merge: TRUE
281
+ merge: YES
282
282
completion: [self completionForExpectationWithName: @" setDataWithMerge" ]];
283
283
[self awaitExpectations ];
284
284
}
Original file line number Diff line number Diff line change @@ -517,8 +517,10 @@ - (nullable FSTFieldValue *)parseData:(id)input context:(FSTParseContext *)conte
517
517
return [self parseDictionary: (NSDictionary *)input context: context];
518
518
519
519
} else if ([input isKindOfClass: [FIRFieldValue class ]]) {
520
- // parseSentinelFieldValue may add an FSTFieldTransform, but nothing should be included in
521
- // the actual parsed data, so we don't add this path to our fieldMask and we return nil.
520
+ // FieldValues usually parse into transforms (except FieldValue.delete()) in which case we
521
+ // do not want to include this field in our parsed data (as doing so will overwrite the field
522
+ // directly prior to the transform trying to transform it). So we don't call appendToFieldMask
523
+ // and we return nil as our parsing result.
522
524
[self parseSentinelFieldValue: (FIRFieldValue *)input context: context];
523
525
return nil ;
524
526
You can’t perform that action at this time.
0 commit comments