Skip to content

Commit 7415a32

Browse files
author
Greg Soltis
authored
Port FSTLevelDBQueryCache to C++ (#2202)
* Port FSTLevelDBQueryCache to C++
1 parent 65f2709 commit 7415a32

File tree

8 files changed

+569
-320
lines changed

8 files changed

+569
-320
lines changed

Firestore/Source/Local/FSTLevelDB.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,7 @@ - (instancetype)initWithLevelDB:(std::unique_ptr<leveldb::DB>)db
345345
[[FSTLevelDBLRUDelegate alloc] initWithPersistence:self lruParams:lruParams];
346346
_transactionRunner.SetBackingPersistence(self);
347347
_users = std::move(users);
348+
// TODO(gsoltis): set up a leveldb transaction for these operations.
348349
[_queryCache start];
349350
[_referenceDelegate start];
350351
}

Firestore/Source/Local/FSTLevelDBQueryCache.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ NS_ASSUME_NONNULL_BEGIN
3838
*/
3939
+ (nullable FSTPBTargetGlobal *)readTargetMetadataFromDB:(leveldb::DB *)db;
4040

41-
/**
42-
* Retrieves the global singleton metadata row using the given transaction, if it exists.
43-
*/
44-
+ (nullable FSTPBTargetGlobal *)readTargetMetadataWithTransaction:
45-
(firebase::firestore::local::LevelDbTransaction *)transaction;
46-
4741
- (instancetype)init NS_UNAVAILABLE;
4842

4943
/**

0 commit comments

Comments
 (0)