review feedback

Author: rsgowman

Firestore/Example/Firestore.xcodeproj/project.pbxproj

@@ -131,7 +131,7 @@
 		6003F5B1195388D20070C39A /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 6003F58D195388D20070C39A /* Foundation.framework */; };
 		6003F5B2195388D20070C39A /* UIKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 6003F591195388D20070C39A /* UIKit.framework */; };
 		6003F5BA195388D20070C39A /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 6003F5B8195388D20070C39A /* InfoPlist.strings */; };
-		61287373203C92C5000EAD3F /* FIRSourceTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 61287372203C92C5000EAD3F /* FIRSourceTests.mm */; };
+		6161B5032047140C00A99DBB /* FIRFirestoreSourceTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 6161B5012047140400A99DBB /* FIRFirestoreSourceTests.mm */; };
 		6ED54761B845349D43DB6B78 /* Pods_Firestore_Example.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 75A6FE51C1A02DF38F62FAAD /* Pods_Firestore_Example.framework */; };
 		71719F9F1E33DC2100824A3D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 71719F9D1E33DC2100824A3D /* LaunchScreen.storyboard */; };
 		7346E61D20325C6900FD6CEF /* FSTDispatchQueueTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7346E61C20325C6900FD6CEF /* FSTDispatchQueueTests.mm */; };
@@ -356,7 +356,7 @@
 		6003F5AF195388D20070C39A /* XCTest.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = XCTest.framework; path = Library/Frameworks/XCTest.framework; sourceTree = DEVELOPER_DIR; };
 		6003F5B7195388D20070C39A /* Tests-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = "Tests-Info.plist"; sourceTree = "<group>"; };
 		6003F5B9195388D20070C39A /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
-		61287372203C92C5000EAD3F /* FIRSourceTests.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FIRSourceTests.mm; sourceTree = "<group>"; };
+		6161B5012047140400A99DBB /* FIRFirestoreSourceTests.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FIRFirestoreSourceTests.mm; sourceTree = "<group>"; };
 		69F6A10DBD6187489481CD76 /* Pods_Firestore_Tests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_Firestore_Tests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
 		71719F9E1E33DC2100824A3D /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
 		7346E61C20325C6900FD6CEF /* FSTDispatchQueueTests.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FSTDispatchQueueTests.mm; sourceTree = "<group>"; };
@@ -884,7 +884,7 @@
 		DE51B1BC1F0D48AC0013853F /* API */ = {
 			isa = PBXGroup;
 			children = (
-				61287372203C92C5000EAD3F /* FIRSourceTests.mm */,
+				6161B5012047140400A99DBB /* FIRFirestoreSourceTests.mm */,
 				5492E070202154D600B64F25 /* FIRCursorTests.mm */,
 				5492E06C202154D500B64F25 /* FIRDatabaseTests.mm */,
 				5492E06A202154D500B64F25 /* FIRFieldsTests.mm */,
@@ -1558,7 +1558,7 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
-				61287373203C92C5000EAD3F /* FIRSourceTests.mm in Sources */,
+				6161B5032047140C00A99DBB /* FIRFirestoreSourceTests.mm in Sources */,
 				5492E076202154D600B64F25 /* FIRValidationTests.mm in Sources */,
 				5492E072202154D600B64F25 /* FIRQueryTests.mm in Sources */,
 				5491BC731FB44593008B3588 /* FSTIntegrationTestCase.mm in Sources */,

Firestore/Example/SwiftBuildTest/main.swift

@@ -32,10 +32,10 @@ func main() {
   addDocument(to: collectionRef)
 
   readDocument(at: documentRef)
-  readDocumentWithOptions(at: documentRef)
+  readDocumentWithSource(at: documentRef)
 
   readDocuments(matching: query)
-  readDocumentsWithOptions(matching: query)
+  readDocumentsWithSource(matching: query)
 
   listenToDocument(at: documentRef)
 
@@ -219,7 +219,7 @@ func readDocument(at docRef: DocumentReference) {
   }
 }
 
-func readDocumentWithOptions(at docRef: DocumentReference) {
+func readDocumentWithSource(at docRef: DocumentReference) {
   docRef.getDocument(source: FirestoreSource.default) { document, error in
   }
   docRef.getDocument(source: .server) { document, error in
@@ -238,7 +238,7 @@ func readDocuments(matching query: Query) {
   }
 }
 
-func readDocumentsWithOptions(matching query: Query) {
+func readDocumentsWithSource(matching query: Query) {
   query.getDocuments(source: FirestoreSource.default) { querySnapshot, error in
   }
   query.getDocuments(source: .server) { querySnapshot, error in

Firestore/Example/Tests/Integration/API/FIRSourceTests.mm renamed to Firestore/Example/Tests/Integration/API/FIRFirestoreSourceTests.mm

@@ -0,0 +1,36 @@
+This file is a concatenation of one or more certificates from this directory.
+
+Taken from testCA:
+-----BEGIN CERTIFICATE-----
+MIICSzCCAbSgAwIBAgIIJNkBrvjQ374wDQYJKoZIhvcNAQELBQAwKjEXMBUGA1UE
+ChMOR29vZ2xlIFRFU1RJTkcxDzANBgNVBAMTBnRlc3RDQTAeFw0xNTAxMDEwMDAw
+MDBaFw0yNTAxMDEwMDAwMDBaMCoxFzAVBgNVBAoTDkdvb2dsZSBURVNUSU5HMQ8w
+DQYDVQQDEwZ0ZXN0Q0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAKmf9KWw
+EujPluTN3wTP+kOU4oTDVn5w+BXNhcxi+19ZkdloJkg3NJ5EwfxAl/4rNJGeuR7X
+nry/+dzkWG+olRTX7dZaV3GzvfFovplqqxDHR76k8i8L4BLE0/Csn3VOamz4zGx8
+r5wyclC8GyMioieGrvi4Wan/SWEKo0/u7wqLAgMBAAGjejB4MA4GA1UdDwEB/wQE
+AwICBDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwDwYDVR0TAQH/BAUw
+AwEB/zAZBgNVHQ4EEgQQp7JSbajiTZaIRUDSV1C81jAbBgNVHSMEFDASgBCnslJt
+qOJNlohFQNJXULzWMA0GCSqGSIb3DQEBCwUAA4GBAH1yvOrs6oMl3FZjpMGfIsq6
+kHqGU7C8XcVhAP/NQJcVT1J/WP/Lcr1e30quqDHPtkKeulBSmUziY1knMDv2NMgT
+LI/b3UwYepftQJoq/t6j1gc3IfVuJ6edcJOacMcdtBaohofZ6S1mnZmllIJgRnbH
+WrIUSk3gcvKUIAUT0myw
+-----END CERTIFICATE-----
+
+Taken from intermediate_ca:
+-----BEGIN CERTIFICATE-----
+MIICfDCCAeWgAwIBAgIJAKJMH+7rscPcMA0GCSqGSIb3DQEBCwUAMD4xFzAVBgNV
+BAoTDkdvb2dsZSBURVNUSU5HMSMwIQYDVQQDExpHb29nbGUgKipUZXN0aW5nKiog
+Um9vdCBDQTAeFw0xNTAxMDEwMDAwMDBaFw0yNTAxMDEwMDAwMDBaMEYxFzAVBgNV
+BAoTDkdvb2dsZSBURVNUSU5HMSswKQYDVQQDEyJHb29nbGUgKipUZXN0aW5nKiog
+SW50ZXJtZWRpYXRlIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC7YtI0
+l8ocTYJ0gKyXTtPL4iMJCNY4OcxXl48jkncVG1HlblicgNUa1r9m9YFtVkxvBinb
+8dXiUpEGhVg4awRPDcatlsBSEBuJkiZGYbRcAmSuCmZYnf6u3aYQ18SU8WqVERPp
+E4cwVVs+6kwlzRw0+XDoZAczu8ZezVhCUc6NbQIDAQABo3oweDAOBgNVHQ8BAf8E
+BAMCAqQwHQYDVR0lBBYwFAYIKwYBBQUHAwEGCCsGAQUFBwMCMA8GA1UdEwEB/wQF
+MAMBAf8wGQYDVR0OBBIEEIwaaKi1dttdV3sfjRSyBqMwGwYDVR0jBBQwEoAQQDfX
+AftAL7gcflQEJ4xZATANBgkqhkiG9w0BAQsFAAOBgQDLEmJdvsRZjslPHJeoSQZ4
+3km6MsJ4cdCNvAR8iegYMWe8wT3+d52fJJaWTN0phjMNYoNwUTmsFJI08bkussv2
+mSJB5ckLJL5Ce5eRYMb4jgWKEQQJyPCQmIkGu2gbtQPfG36amVfxjsnqJCbgBIt4
+349bmquJfjx4kOhoPVVH9Q==
+-----END CERTIFICATE-----