Skip to content

Commit 85c7a3b

Browse files
authored
Update README for tvOS and include in travis (#587)
1 parent bfcfa0a commit 85c7a3b

File tree

2 files changed

+29
-10
lines changed

2 files changed

+29
-10
lines changed

README.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -132,16 +132,18 @@ We've seen an amazing amount of interest and contributions to improve the Fireba
132132
very grateful! We'd like to empower as many developers as we can to be able to use Firebase and
133133
participate in the Firebase community.
134134

135-
### macOS
135+
### macOS and tvOS
136136
FirebaseAuth, FirebaseCore, FirebaseDatabase and FirebaseStorage now compile, run unit tests, and
137-
work on macOS, thanks to contributions from the community. There are a few tweaks needed, like
138-
ensuring iOS-only or macOS-only code is correctly guarded with checks for `TARGET_OS_IOS` and
139-
`TARGET_OS_OSX`.
140-
141-
Keep in mind that macOS is not officially supported by Firebase, and this repository is actively
142-
developed primarily for iOS. While we can catch basic unit test issues with Travis, there may be
143-
some changes where the SDK no longer works as expected on macOS. If you encounter this, please
144-
[file an issue](https://github.com/firebase/firebase-ios-sdk/issues) for it.
137+
work on macOS and tvOS, thanks to contributions from the community. There are a few tweaks needed,
138+
like ensuring iOS-only, macOS-only, or tvOS-only code is correctly guarded with checks for
139+
`TARGET_OS_IOS`, `TARGET_OS_OSX` and `TARGET_OS_TV`.
140+
141+
For tvOS, checkout the [Sample](Example/tvOSSample).
142+
143+
Keep in mind that macOS and tvOS are not officially supported by Firebase, and this repository is
144+
actively developed primarily for iOS. While we can catch basic unit test issues with Travis, there
145+
may be some changes where the SDK no longer works as expected on macOS or tvOS. If you encounter
146+
this, please [file an issue](https://github.com/firebase/firebase-ios-sdk/issues).
145147

146148
## Roadmap
147149

test.sh

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ test_iOS() {
1818
-workspace Example/Firebase.xcworkspace \
1919
-scheme AllUnitTests_iOS \
2020
-sdk iphonesimulator \
21-
-destination 'platform=iOS Simulator,OS=10.3.1,name=iPhone 7' \
21+
-destination 'platform=iOS Simulator,name=iPhone 7' \
2222
build \
2323
test \
2424
ONLY_ACTIVE_ARCH=YES \
@@ -39,6 +39,19 @@ test_macOS() {
3939
| xcpretty
4040
}
4141

42+
test_tvOS() {
43+
xcodebuild \
44+
-workspace Example/Firebase.xcworkspace \
45+
-scheme AllUnitTests_tvOS \
46+
-sdk appletvsimulator \
47+
-destination 'platform=tvOS Simulator,name=Apple TV' \
48+
build \
49+
test \
50+
ONLY_ACTIVE_ARCH=YES \
51+
CODE_SIGNING_REQUIRED=NO \
52+
| xcpretty
53+
}
54+
4255
test_iOS; RESULT=$?
4356

4457
if [ $RESULT != 0 ]; then exit $RESULT; fi
@@ -54,5 +67,9 @@ fi
5467

5568
if [ $RESULT != 0 ]; then exit $RESULT; fi
5669

70+
test_tvOS; RESULT=$?
71+
72+
if [ $RESULT != 0 ]; then exit $RESULT; fi
73+
5774
# Also test Firestore
5875
Firestore/test.sh

0 commit comments

Comments
 (0)