Skip to content

Commit ac7af90

Browse files
Ignoring stream messages for closed streams
1 parent 47653ce commit ac7af90

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Firestore/Source/Remote/FSTStream.m

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ - (void)handleStreamMessage:(id)value {
516516
- (void)handleStreamClose:(nullable NSError *)error {
517517
FSTLog(@"%@ %p close: %@", NSStringFromClass([self class]), (__bridge void *)self, error);
518518

519-
if (![self isStarted]) { // The stream could have already been closed by the idle close timer.
519+
if (![self isStarted]) { // The stream could have already been closed by the idle close timer.
520520
FSTLog(@"%@ Ignoring server close for already closed stream.", NSStringFromClass([self class]));
521521
return;
522522
}
@@ -542,9 +542,10 @@ - (void)writeValue:(id)value __used {
542542
FSTWeakify(self);
543543
[self.workerDispatchQueue dispatchAsync:^{
544544
FSTStrongify(self);
545-
if (!self || self.state == FSTStreamStateStopped) {
546-
return;
545+
if (!self || ![self isStarted]) {
546+
FSTLog(@"%@ Ignoring stream message from inactive stream.", NSStringFromClass([self class]));
547547
}
548+
548549
if (!self.messageReceived) {
549550
self.messageReceived = YES;
550551
if ([FIRFirestore isLoggingEnabled]) {

0 commit comments

Comments
 (0)