Skip to content

Commit cd0cbe9

Browse files
wilhuffzxu123
authored andcommitted
Use Comparator in FieldValue. (#686)
1 parent 39d8252 commit cd0cbe9

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Firestore/core/src/firebase/firestore/model/field_value.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,11 @@
2121
#include <utility>
2222
#include <vector>
2323

24+
#include "Firestore/core/src/firebase/firestore/util/comparison.h"
2425
#include "Firestore/core/src/firebase/firestore/util/firebase_assert.h"
2526

27+
using firebase::firestore::util::Comparator;
28+
2629
namespace firebase {
2730
namespace firestore {
2831
namespace model {
@@ -137,8 +140,7 @@ bool operator<(const FieldValue& lhs, const FieldValue& rhs) {
137140
case Type::Null:
138141
return false;
139142
case Type::Boolean:
140-
// lhs < rhs iff lhs == false and rhs == true.
141-
return !lhs.boolean_value_ && rhs.boolean_value_;
143+
return Comparator<bool>()(lhs.boolean_value_, rhs.boolean_value_);
142144
case Type::Array:
143145
return lhs.array_value_ < rhs.array_value_;
144146
default:

0 commit comments

Comments
 (0)