Skip to content

Commit e374338

Browse files
authored
Fix removal of view references in FSTLocalStore (#3737)
1 parent 3a2077f commit e374338

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Firestore/Example/Tests/Local/FSTLocalStoreTests.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -806,10 +806,10 @@ - (void)testPinsDocumentsInTheLocalView {
806806
FSTAssertContains(Doc("foo/baz", 2, Map("foo", "baz")));
807807

808808
[self notifyLocalViewChanges:TestViewChanges(targetID, @[], @[ @"foo/bar", @"foo/baz" ])];
809-
[self.localStore releaseQuery:query];
810-
811809
FSTAssertNotContains("foo/bar");
812810
FSTAssertNotContains("foo/baz");
811+
812+
[self.localStore releaseQuery:query];
813813
}
814814

815815
- (void)testThrowsAwayDocumentsWithUnknownTargetIDsImmediately {

Firestore/Source/Local/FSTLocalStore.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ - (void)notifyLocalViewChanges:(const std::vector<LocalViewChanges> &)viewChange
414414
[self->_persistence.referenceDelegate removeReference:key];
415415
}
416416
_localViewReferences.AddReferences(viewChange.added_keys(), viewChange.target_id());
417-
_localViewReferences.AddReferences(viewChange.removed_keys(), viewChange.target_id());
417+
_localViewReferences.RemoveReferences(viewChange.removed_keys(), viewChange.target_id());
418418
}
419419
});
420420
}

0 commit comments

Comments
 (0)