Skip to content

Commit ea3369c

Browse files
authored
Use angle brackets for nonlocal #includes in Firestore (#580)
1 parent 6839851 commit ea3369c

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

Firestore/Example/Firestore.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1451,6 +1451,7 @@
14511451
"$(inherited)",
14521452
"\"${PODS_ROOT}/../../..\"",
14531453
"\"${PODS_ROOT}/leveldb-library/include\"",
1454+
"\"${PODS_ROOT}/GoogleTest/googletest/include\"",
14541455
);
14551456
INFOPLIST_FILE = "Tests/Tests-Info.plist";
14561457
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.${PRODUCT_NAME:rfc1034identifier}";
@@ -1482,6 +1483,7 @@
14821483
"$(inherited)",
14831484
"\"${PODS_ROOT}/../../..\"",
14841485
"\"${PODS_ROOT}/leveldb-library/include\"",
1486+
"\"${PODS_ROOT}/GoogleTest/googletest/include\"",
14851487
);
14861488
INFOPLIST_FILE = "Tests/Tests-Info.plist";
14871489
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.${PRODUCT_NAME:rfc1034identifier}";

Firestore/Example/Tests/GoogleTest/FSTGoogleTestTests.mm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@
1717
#import <XCTest/XCTest.h>
1818
#import <objc/runtime.h>
1919

20+
#include <gtest/gtest.h>
21+
2022
#include "Firestore/Source/Util/FSTAssert.h"
21-
#include "gtest/gtest.h"
2223

2324
/**
2425
* An XCTest test case that finds C++ test cases written in the GoogleTest framework, runs them, and

Firestore/Port/string_util_test.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@
1616

1717
#include "Firestore/Port/string_util.h"
1818

19-
#include "leveldb/db.h"
20-
21-
#include "gtest/gtest.h"
19+
#include <gtest/gtest.h>
20+
#include <leveldb/db.h>
2221

2322
using Firestore::PrefixSuccessor;
2423
using Firestore::ImmediateSuccessor;

Firestore/core/test/firebase/firestore/util/autoid_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
#include <ctype.h>
2020

21-
#include "gtest/gtest.h"
21+
#include <gtest/gtest.h>
2222

2323
using firebase::firestore::util::CreateAutoId;
2424

Firestore/core/test/firebase/firestore/util/secure_random_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Firestore/core/src/firebase/firestore/util/secure_random.h"
1818

19-
#include "gtest/gtest.h"
19+
#include <gtest/gtest.h>
2020

2121
using firebase::firestore::util::SecureRandom;
2222

0 commit comments

Comments
 (0)