-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RemoteConfig SQLite crash #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mohammedshahid please symbolicate your stack trace and post the symbolicated stack trace here. |
Also, let us know the versions of the Firebase pods. |
Pod Versions used : |
Please check the updated symbolicated stack trace below :
|
Looks like this is crashing in a sqlite call we're making in RemoteConfig. Does this happen deterministically? Can you share repro steps? |
Hey , we haven’t got this while debugging or testing . But we got a lot of crashes in production because of this issue only for iOS 12 users . Does this have anything to do with lower Expiration Duraiton to fetch the RemoteConfig ? - we have it set to 120 seconds |
Expiration duration shouldn't affect this crash. |
Hi guys , any update on this issue . |
It'll be difficult for us to make progress on this crash without repro steps. |
Looks like an issue similar to this - #1966 (Unlock of an os_unfair_lock not owned by current thread" in iOS12) |
Hi @paulb777 @morganchen12 - I had got this issue while debugging in simulator but its not reproducible. Please take look at the screenshots & let me know if i have to do something to fix this crash that's happening a lot for our users. FYI, Thread 3 has crashed and It happens on APP LAUNCH even before the FIR Configure is called . |
This could potentially be a threading issue in Remote Config. @dmandar, can you investigate? |
We have some pending changes in this area that should address this crash. They're part of a larger partial rewrite change, though, so it'll be some time before they're released. In the meantime, if anyone has repro steps, we can try to verify the fixes before release. |
@mohammedshahid can you share your code or any sample that reproduces this issue? |
@morganchen12 - Hey Apologies we can't share the code and even if we do that it's hardly reproducible . We get this issue at random with no specific steps, but surely it happens at app launch when we call - self.firebase.setDefaults(defaultConfig as? [String : NSObject]) |
We also have a crash
as soon as the app starts. |
@kwstasna - I would recommend you not to use the { setDefaults(fromPlist: "") or setDefaults(fromDict: "") } method of firebase, Instead write a helper method to fetch yourself that would give you the defaults when required. Helper in Swift : func getDataValueForKey(_ key : String)-> Data It solved our issue of crashes. |
@kwstasna, @mohammedshahid -- have either of you seen this crash happening recently? |
@morganchen12 we see lots of crashes with the following crashlytics reports.
Each line is a separate crash. |
@kwstasna can you share the full stack trace for each crash? |
Fix up internally at cr/252923920. |
Fix has been merged. |
Uh oh!
There was an error while loading. Please reload this page.
We have integrated Firebase Remote Config , Performance in our iOS app.
With Recent iOS 12 update the crashes started showing up crashes in Fabric with logs below.
Crash log for your reference with the particular thread that crashed :
Crashed: com.google.GoogleConfigService.database
EXC_BREAKPOINT 0x00000001f7bc1158
Could you please update on this.
The text was updated successfully, but these errors were encountered: