Skip to content

Memory leak at [FSTSerializerBeta decodeFieldvalue] #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willtr101 opened this issue Dec 14, 2018 · 2 comments
Closed

Memory leak at [FSTSerializerBeta decodeFieldvalue] #2189

willtr101 opened this issue Dec 14, 2018 · 2 comments

Comments

@willtr101
Copy link

.### [REQUIRED] Step 2: Describe your environment

  • Xcode version: 10.1
  • Firebase SDK version: 5.14.0
  • Firebase Component: Firestore
  • Component version: 0.16.1

[REQUIRED] Step 3: Describe the problem

We found memory leaks from Firestore the Instruments tool while tracing leaks from other SDK.

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
image

@wilhuff
Copy link
Contributor

wilhuff commented Dec 17, 2018

I can't reproduce a leak in FSTSerializerBeta, either using our tests or a sample application. Looking at the code I can't see an unbalanced retain/release there either. I did find some other leaks related to SCNetworkReachability and a gRPC leak in FillMetadataArray that I'll look at now.

Can you give some more detail about what you might have been doing to trigger this? Things that might be interesting are the shape of your data or the way you access it.

Also could you get a full copy of that stack trace? It's possible that the leak is not local the the serializer. You can get the stack in text form In Instruments by selecting all stack frames, copying, and pasting into a text editor.

@wilhuff
Copy link
Contributor

wilhuff commented Dec 19, 2018

Absent more data there's not much I can do about this because I can't find any leak resembling this. Those I did find were fixed in the PR above.

If you are still able to see the leak in FSTSerializerBeta and can provide the additional information requested above we can reopen this and address it.

@wilhuff wilhuff closed this as completed Dec 19, 2018
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants