Skip to content

Source formatting for Swift #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilhuff opened this issue Feb 22, 2018 · 1 comment · Fixed by #847
Closed

Source formatting for Swift #839

wilhuff opened this issue Feb 22, 2018 · 1 comment · Fixed by #847
Labels
help wanted

Comments

@wilhuff
Copy link
Contributor

wilhuff commented Feb 22, 2018

scripts/style.sh is based on clang-format and we have it set up to format our Objective-C, Objective-C++, and C++ code. Extending this to format .swift files broke them horribly.

SwiftFormat looks promising. We should integrate it into scripts/style.sh for swift sources.
@ryanwilson
Copy link
Member

There's a bunch of work being done right now on libSyntax that we should be able to take advantage of, too.

@wilhuff wilhuff mentioned this issue Feb 24, 2018
Merged
@firebase firebase locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto-style swift sources firebase/firebase-ios-sdk
2 participants
@ryanwilson @wilhuff