From f47cd249bb1c88baaa41d9ecfac7946a6b1f57ab Mon Sep 17 00:00:00 2001 From: Paul Beusterien Date: Thu, 21 Dec 2017 10:47:59 -0800 Subject: [PATCH] Update README for tvOS and include in travis --- README.md | 20 +++++++++++--------- test.sh | 19 ++++++++++++++++++- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index e14e096c8a6..9e2f8ea4140 100644 --- a/README.md +++ b/README.md @@ -132,16 +132,18 @@ We've seen an amazing amount of interest and contributions to improve the Fireba very grateful! We'd like to empower as many developers as we can to be able to use Firebase and participate in the Firebase community. -### macOS +### macOS and tvOS FirebaseAuth, FirebaseCore, FirebaseDatabase and FirebaseStorage now compile, run unit tests, and -work on macOS, thanks to contributions from the community. There are a few tweaks needed, like -ensuring iOS-only or macOS-only code is correctly guarded with checks for `TARGET_OS_IOS` and -`TARGET_OS_OSX`. - -Keep in mind that macOS is not officially supported by Firebase, and this repository is actively -developed primarily for iOS. While we can catch basic unit test issues with Travis, there may be -some changes where the SDK no longer works as expected on macOS. If you encounter this, please -[file an issue](https://github.com/firebase/firebase-ios-sdk/issues) for it. +work on macOS and tvOS, thanks to contributions from the community. There are a few tweaks needed, +like ensuring iOS-only, macOS-only, or tvOS-only code is correctly guarded with checks for +`TARGET_OS_IOS`, `TARGET_OS_OSX` and `TARGET_OS_TV`. + +For tvOS, checkout the [Sample](Example/tvOSSample). + +Keep in mind that macOS and tvOS are not officially supported by Firebase, and this repository is +actively developed primarily for iOS. While we can catch basic unit test issues with Travis, there +may be some changes where the SDK no longer works as expected on macOS or tvOS. If you encounter +this, please [file an issue](https://github.com/firebase/firebase-ios-sdk/issues). ## Roadmap diff --git a/test.sh b/test.sh index 627fbad9c6a..367205a9110 100755 --- a/test.sh +++ b/test.sh @@ -18,7 +18,7 @@ test_iOS() { -workspace Example/Firebase.xcworkspace \ -scheme AllUnitTests_iOS \ -sdk iphonesimulator \ - -destination 'platform=iOS Simulator,OS=10.3.1,name=iPhone 7' \ + -destination 'platform=iOS Simulator,name=iPhone 7' \ build \ test \ ONLY_ACTIVE_ARCH=YES \ @@ -39,6 +39,19 @@ test_macOS() { | xcpretty } +test_tvOS() { + xcodebuild \ + -workspace Example/Firebase.xcworkspace \ + -scheme AllUnitTests_tvOS \ + -sdk appletvsimulator \ + -destination 'platform=tvOS Simulator,name=Apple TV' \ + build \ + test \ + ONLY_ACTIVE_ARCH=YES \ + CODE_SIGNING_REQUIRED=NO \ + | xcpretty +} + test_iOS; RESULT=$? if [ $RESULT != 0 ]; then exit $RESULT; fi @@ -54,5 +67,9 @@ fi if [ $RESULT != 0 ]; then exit $RESULT; fi +test_tvOS; RESULT=$? + +if [ $RESULT != 0 ]; then exit $RESULT; fi + # Also test Firestore Firestore/test.sh