Make fixes to ListenerType

Author: hsubox76

packages-exp/app-check-exp/src/api.ts

@@ -231,7 +231,7 @@ export function onTokenChanged(
   }
   addTokenListener(
     appCheckInstance as AppCheckService,
-    ListenerType['3P'],
+    ListenerType.EXTERNAL,
     nextFn,
     errorFn
   );

packages-exp/app-check-exp/src/factory.ts

@@ -51,7 +51,7 @@ export function internalFactory(
   return {
     getToken: forceRefresh => getToken(appCheck, forceRefresh),
     addTokenListener: listener =>
-      addTokenListener(appCheck, ListenerType['2P'], listener),
+      addTokenListener(appCheck, ListenerType.INTERNAL, listener),
     removeTokenListener: listener => removeTokenListener(appCheck.app, listener)
   };
 }

packages-exp/app-check-exp/src/internal-api.test.ts

@@ -158,12 +158,12 @@ describe('internal api', () => {
       const listener2 = spy();
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener1
       );
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener2
       );
 
@@ -196,12 +196,12 @@ describe('internal api', () => {
       const listener2 = spy();
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener1
       );
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener2
       );
 
@@ -227,7 +227,7 @@ describe('internal api', () => {
 
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['3P'],
+        ListenerType.EXTERNAL,
         listener1,
         errorFn1
       );
@@ -254,12 +254,12 @@ describe('internal api', () => {
 
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener1
       );
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener2
       );
 
@@ -371,7 +371,7 @@ describe('internal api', () => {
 
       addTokenListener(
         { app } as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
 
@@ -386,7 +386,7 @@ describe('internal api', () => {
 
       addTokenListener(
         { app } as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
 
@@ -414,7 +414,7 @@ describe('internal api', () => {
 
       addTokenListener(
         { app } as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         fakeListener
       );
     });
@@ -443,7 +443,7 @@ describe('internal api', () => {
 
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         fakeListener
       );
 
@@ -468,7 +468,7 @@ describe('internal api', () => {
       });
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         fakeListener
       );
     });
@@ -484,7 +484,7 @@ describe('internal api', () => {
       });
       addTokenListener(
         appCheck as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         () => {}
       );
 
@@ -498,7 +498,7 @@ describe('internal api', () => {
       const listener = (): void => {};
       addTokenListener(
         { app } as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
       expect(getState(app).tokenObservers.length).to.equal(1);
@@ -513,7 +513,7 @@ describe('internal api', () => {
 
       addTokenListener(
         { app } as AppCheckService,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
       expect(getState(app).tokenObservers.length).to.equal(1);

packages-exp/app-check-exp/src/internal-api.ts

@@ -284,7 +284,7 @@ function notifyTokenListeners(
 
   for (const observer of observers) {
     try {
-      if (observer.type === ListenerType['3P'] && token.error != null) {
+      if (observer.type === ListenerType.EXTERNAL && token.error != null) {
         // If this listener was added by a 3P call, send any token error to
         // the supplied error handler. A 3P observer always has an error
         // handler.

packages-exp/app-check-exp/src/types.ts

@@ -42,8 +42,10 @@ export interface AppCheckTokenObserver
 }
 
 export const enum ListenerType {
-  '2P' = '2P',
-  '3P' = '3P'
+  // Listener added by a 2P library.
+  'INTERNAL' = 'INTERNAL',
+  // Listener added by users using the public API.
+  'EXTERNAL' = 'EXTERNAL'
 }
 
 // If the error field is defined, the token field will be populated with a dummy token

packages-exp/app-check-exp/tsconfig.json

@@ -2,8 +2,7 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "strict": true,
-    "preserveConstEnums": true
+    "strict": true
   },
   "exclude": ["dist/**/*"]
 }