Skip to content

Commit 227a980

Browse files
committed
fix lint issues after rebasing with master
1 parent bd4c662 commit 227a980

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

packages/firestore/src/core/query.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,9 +618,6 @@ export class FieldFilter extends Filter {
618618

619619
/** Filter that matches on key fields (i.e. '__name__'). */
620620
export class KeyFieldFilter extends FieldFilter {
621-
constructor(field: FieldPath, op: Operator, value: RefValue) {
622-
super(field, op, value);
623-
}
624621

625622
matches(doc: Document): boolean {
626623
const refValue = this.value as RefValue;

packages/firestore/src/remote/serializer.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ import { Code, FirestoreError } from '../util/error';
5252
import * as obj from '../util/obj';
5353
import * as typeUtils from '../util/types';
5454

55-
import { DoubleValue, NullValue, NumberValue } from '../model/field_value';
5655
import {
5756
ArrayRemoveTransformOperation,
5857
ArrayUnionTransformOperation,
@@ -1158,7 +1157,7 @@ export class JsonProtoSerializer {
11581157
}
11591158

11601159
private toFilter(filters: Filter[]): api.Filter | undefined {
1161-
if (filters.length === 0) return;
1160+
if (filters.length === 0) {return;}
11621161
const protos = filters.map(filter => {
11631162
if (filter instanceof FieldFilter) {
11641163
return this.toUnaryOrFieldFilter(filter);
@@ -1293,14 +1292,14 @@ export class JsonProtoSerializer {
12931292
// visible for testing
12941293
toUnaryOrFieldFilter(filter: FieldFilter): api.Filter {
12951294
if (filter.op === Operator.EQUAL) {
1296-
if (filter.value.isEqual(DoubleValue.NAN)) {
1295+
if (filter.value.isEqual(fieldValue.DoubleValue.NAN)) {
12971296
return {
12981297
unaryFilter: {
12991298
field: this.toFieldPathReference(filter.field),
13001299
op: 'IS_NAN'
13011300
}
13021301
};
1303-
} else if (filter.value.isEqual(NullValue.INSTANCE)) {
1302+
} else if (filter.value.isEqual(fieldValue.NullValue.INSTANCE)) {
13041303
return {
13051304
unaryFilter: {
13061305
field: this.toFieldPathReference(filter.field),
@@ -1324,12 +1323,12 @@ export class JsonProtoSerializer {
13241323
const nanField = this.fromFieldPathReference(
13251324
filter.unaryFilter!.field!
13261325
);
1327-
return new FieldFilter(nanField, Operator.EQUAL, DoubleValue.NAN);
1326+
return new FieldFilter(nanField, Operator.EQUAL, fieldValue.DoubleValue.NAN);
13281327
case 'IS_NULL':
13291328
const nullField = this.fromFieldPathReference(
13301329
filter.unaryFilter!.field!
13311330
);
1332-
return new FieldFilter(nullField, Operator.EQUAL, NullValue.INSTANCE);
1331+
return new FieldFilter(nullField, Operator.EQUAL, fieldValue.NullValue.INSTANCE);
13331332
case 'OPERATOR_UNSPECIFIED':
13341333
return fail('Unspecified filter');
13351334
default:

0 commit comments

Comments
 (0)