Skip to content

Commit 4c3fa4c

Browse files
Comment cleanup
1 parent c5099ff commit 4c3fa4c

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

packages/firestore/src/local/tab_notification_channel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ export interface TabNotificationChannel {
6262
getAllActiveQueryTargets(): Set<TargetId>;
6363

6464
/**
65-
* Starts the TabNotificationChannel, reads existing instance data for all
65+
* Starts the TabNotificationChannel, reads existing instance data for all
6666
* `knownInstances` and registers listeners for newly added instances.
6767
*/
6868
start(knownInstances: InstanceKey[]): void;
6969

70-
/** Shutdown the `TabNotificationChannel` and its listeners. */
70+
/** Shuts down the `TabNotificationChannel` and its listeners. */
7171
shutdown(): void;
7272
}
7373

packages/firestore/test/unit/local/local_storage_notification_channel.test.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,13 @@ describe('LocalStorageNotificationChannel', () => {
8787
});
8888
});
8989

90-
it('with one batch', () => {
91-
notificationChannel.addPendingMutation(0);
92-
assertInstanceState([], 0, 0);
90+
it('with empty batch', () => {
91+
assertInstanceState([]);
9392
});
9493

95-
it('with empty batch', () => {
94+
it('with one batch', () => {
9695
notificationChannel.addPendingMutation(0);
97-
notificationChannel.removePendingMutation(0);
98-
assertInstanceState([]);
96+
assertInstanceState([], 0, 0);
9997
});
10098

10199
it('with multiple batches', () => {
@@ -123,8 +121,6 @@ describe('LocalStorageNotificationChannel', () => {
123121
});
124122

125123
it('with empty targets', () => {
126-
notificationChannel.addActiveQueryTarget(0);
127-
notificationChannel.removeActiveQueryTarget(0);
128124
assertInstanceState([]);
129125
});
130126

0 commit comments

Comments
 (0)