Skip to content

Commit 76c3641

Browse files
authored
Use ubuntu-latest for Firefox CI tests (#8671)
1 parent cbec4b9 commit 76c3641

File tree

3 files changed

+8
-30
lines changed

3 files changed

+8
-30
lines changed

.github/workflows/test-changed-auth.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,19 +70,12 @@ jobs:
7070
run: xvfb-run yarn test:changed auth
7171
test-firefox:
7272
name: Test Auth on Firefox If Changed
73-
# Whatever version of Firefox comes with 22.04 is causing Firefox
74-
# startup to hang when launched by karma. Need to look further into
75-
# why.
7673

77-
runs-on: ubuntu-20.04
74+
runs-on: ubuntu-latest
7875

7976
steps:
8077
- name: install Firefox stable
81-
run: |
82-
sudo apt-get update
83-
sudo apt-get install firefox
84-
sudo apt-get install wget
85-
78+
run: npx @puppeteer/browsers install firefox@stable
8679
- name: Checkout Repo
8780
uses: actions/checkout@v4
8881
with:

.github/workflows/test-changed-firestore.yml

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -169,17 +169,12 @@ jobs:
169169

170170
compat-test-firefox:
171171
name: Test Firestore Compatible on Firefox
172-
# Whatever version of Firefox comes with 22.04 is causing Firefox
173-
# startup to hang when launched by karma. Need to look further into
174-
# why.
175-
runs-on: ubuntu-20.04
172+
runs-on: ubuntu-latest
176173
needs: build
177174
if: ${{ needs.build.outputs.changed == 'true'}}
178175
steps:
179176
- name: install Firefox stable
180-
run: |
181-
sudo apt-get update
182-
sudo apt-get install firefox
177+
run: npx @puppeteer/browsers install firefox@stable
183178
- name: Set up Node (20)
184179
uses: actions/setup-node@v3
185180
with:
@@ -202,17 +197,12 @@ jobs:
202197
strategy:
203198
matrix:
204199
test-name: ["test:browser", "test:travis", "test:lite:browser", "test:browser:prod:nameddb", "test:lite:browser:nameddb"]
205-
# Whatever version of Firefox comes with 22.04 is causing Firefox
206-
# startup to hang when launched by karma. Need to look further into
207-
# why.
208-
runs-on: ubuntu-20.04
200+
runs-on: ubuntu-latest
209201
needs: build
210202
if: ${{ needs.build.outputs.changed == 'true'}}
211203
steps:
212204
- name: install Firefox stable
213-
run: |
214-
sudo apt-get update
215-
sudo apt-get install firefox
205+
run: npx @puppeteer/browsers install firefox@stable
216206
- name: Download build archive
217207
uses: actions/download-artifact@v3
218208
with:

.github/workflows/test-changed.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,7 @@ jobs:
5050

5151
test-firefox:
5252
name: Test Packages With Changed Files in Firefox
53-
# Whatever version of Firefox comes with 22.04 is causing Firefox
54-
# startup to hang when launched by karma. Need to look further into
55-
# why.
56-
runs-on: ubuntu-20.04
53+
runs-on: ubuntu-latest
5754

5855
steps:
5956
- name: Checkout Repo
@@ -65,9 +62,7 @@ jobs:
6562
with:
6663
node-version: 22.10.0
6764
- name: install Firefox stable
68-
run: |
69-
sudo apt-get update
70-
sudo apt-get install firefox
65+
run: npx @puppeteer/browsers install firefox@stable
7166
- name: Test setup and yarn install
7267
run: |
7368
cp config/ci.config.json config/project.json

0 commit comments

Comments
 (0)