Skip to content

Commit 960ce1e

Browse files
committed
use documentKeySet.
1 parent 66c9330 commit 960ce1e

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

packages/firestore/src/local/memory_document_overlay_cache.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
*/
1717

1818
import {
19+
documentKeySet,
1920
DocumentKeySet,
2021
DocumentKeyToMutationMap,
2122
DocumentKeyToOverlayMap,
@@ -26,7 +27,6 @@ import { Mutation } from '../model/mutation';
2627
import { Overlay } from '../model/overlay';
2728
import { ResourcePath } from '../model/path';
2829
import { SortedMap } from '../util/sorted_map';
29-
import { SortedSet } from '../util/sorted_set';
3030

3131
import { DocumentOverlayCache } from './document_overlay_cache';
3232
import { PersistencePromise } from './persistence_promise';
@@ -173,7 +173,7 @@ export class MemoryDocumentOverlayCache implements DocumentOverlayCache {
173173
// Create the association of this overlay to the given largestBatchId.
174174
let batch = this.overlayByBatchId.get(largestBatchId);
175175
if (batch === undefined) {
176-
batch = new SortedSet(DocumentKey.comparator);
176+
batch = documentKeySet();
177177
this.overlayByBatchId.set(largestBatchId, batch);
178178
}
179179
this.overlayByBatchId.set(largestBatchId, batch.add(mutation.key));

packages/firestore/test/unit/local/document_overlay_cache.test.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,11 @@ import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
2121
import { Persistence } from '../../../src/local/persistence';
2222
import {
2323
documentKeySet,
24-
DocumentKeySet,
2524
DocumentKeyToMutationMap,
2625
DocumentKeyToOverlayMap,
2726
newDocumentKeyToMutationMap
2827
} from '../../../src/model/collections';
29-
import { DocumentKey } from '../../../src/model/document_key';
3028
import { Mutation, mutationEquals } from '../../../src/model/mutation';
31-
import { SortedSet } from '../../../src/util/sorted_set';
3229
import { addEqualityMatcher } from '../../util/equality_matcher';
3330
import {
3431
deleteMutation,
@@ -124,10 +121,10 @@ function genericDocumentOverlayCacheTests(): void {
124121
overlays: DocumentKeyToOverlayMap,
125122
...keys: string[]
126123
): void {
127-
const overlayKeys: DocumentKeySet = new SortedSet(DocumentKey.comparator);
128-
overlays.forEach(overlayKey => overlayKeys.add(overlayKey));
129-
const expectedKeys: DocumentKeySet = new SortedSet(DocumentKey.comparator);
130-
keys.forEach(value => expectedKeys.add(key(value)));
124+
let overlayKeys = documentKeySet();
125+
overlays.forEach(overlayKey => (overlayKeys = overlayKeys.add(overlayKey)));
126+
let expectedKeys = documentKeySet();
127+
keys.forEach(value => (expectedKeys = expectedKeys.add(key(value))));
131128
expect(overlayKeys.isEqual(expectedKeys)).to.deep.equal(true);
132129
}
133130

0 commit comments

Comments
 (0)