Skip to content

Commit fd41378

Browse files
davideasthiranya911
authored andcommitted
Rxfire build fix (#1085)
* fix rxfire build * [AUTOMATED]: Prettier Code Styling
1 parent 22ed571 commit fd41378

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

packages/rxfire/.gitignore

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,15 @@
55

66
# generated declaration files
77
# declaration files currently break testing builds
8-
# TODO: Fix TypeScript build setup before release
98
auth/index.d.ts
109
firestore/collection/index.d.ts
1110
firestore/document/index.d.ts
1211
firestore/fromRef.d.ts
1312
firestore/index.d.ts
13+
database/fromRef.d.ts
14+
database/interfaces.d.ts
15+
database/utils.d.ts
16+
database/list/audit-trail.d.ts
1417
functions/index.d.ts
1518
index.d.ts
1619
storage/index.d.ts

packages/rxfire/package.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,12 @@
3131
"browser": "dist/index.cjs.js",
3232
"module": "dist/index.esm.js",
3333
"peerDependencies": {
34-
"firebase": "5.2.0",
35-
"rxjs": "6.2.0"
34+
"firebase": "^5.3.0",
35+
"rxjs": "^6.2.2"
3636
},
3737
"devDependencies": {
38+
"firebase": "^5.3.0",
39+
"rxjs": "^6.2.2",
3840
"rollup": "0.57.1",
3941
"rollup-plugin-commonjs": "9.1.0",
4042
"rollup-plugin-node-resolve": "3.3.0",

packages/rxfire/test/firestore.test.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { initializeApp, firestore, app } from 'firebase/app';
1818
import 'firebase/firestore';
1919
import {
2020
collection,
21-
docChanges,
21+
collectionChanges,
2222
sortedChanges,
2323
auditTrail,
2424
docData,
@@ -112,7 +112,7 @@ describe('RxFire Firestore', () => {
112112
});
113113
});
114114

115-
describe('docChanges', () => {
115+
describe('collectionChanges', () => {
116116
/**
117117
* The `stateChanges()` method emits a stream of events as they
118118
* occur rather than in sorted order.
@@ -124,8 +124,8 @@ describe('RxFire Firestore', () => {
124124
const { colRef, davidDoc } = seedTest(firestore);
125125

126126
davidDoc.set({ name: 'David' });
127-
const firstChange = docChanges(colRef).pipe(take(1));
128-
const secondChange = docChanges(colRef).pipe(skip(1));
127+
const firstChange = collectionChanges(colRef).pipe(take(1));
128+
const secondChange = collectionChanges(colRef).pipe(skip(1));
129129

130130
firstChange.subscribe(change => {
131131
expect(change[0].type).to.eq('added');
@@ -141,7 +141,7 @@ describe('RxFire Firestore', () => {
141141

142142
describe('sortedChanges', () => {
143143
/**
144-
* The `sortedChanges()` method reduces the stream of `docChanges()` to
144+
* The `sortedChanges()` method reduces the stream of `collectionChanges()` to
145145
* a sorted array. This test seeds two "people" and checks to make sure
146146
* the 'added' change type exists. Afterwards, one "person" is modified.
147147
* The test then checks that the person is modified and in the proper sorted

0 commit comments

Comments
 (0)