From d7d8aa4d62a4297a537ec327343fbb241e52162a Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Wed, 24 Jul 2024 14:46:23 -0700 Subject: [PATCH 1/3] test --- packages/analytics/src/api.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/analytics/src/api.ts b/packages/analytics/src/api.ts index baf136b3e35..2e5a0dde26d 100644 --- a/packages/analytics/src/api.ts +++ b/packages/analytics/src/api.ts @@ -16,7 +16,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - +//fsdj import { _getProvider, FirebaseApp, getApp } from '@firebase/app'; import { Analytics, @@ -63,6 +63,8 @@ declare module '@firebase/component' { } } +console.log('hi'); + /** * Returns an {@link Analytics} instance for the given app. * From 17665d91badbbe697b79fa5cbba2a5a676803dfd Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Wed, 24 Jul 2024 14:55:17 -0700 Subject: [PATCH 2/3] add a pattern check --- packages/analytics/src/api.ts | 4 +--- scripts/ci/check_changeset.ts | 5 ++++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/analytics/src/api.ts b/packages/analytics/src/api.ts index 2e5a0dde26d..baf136b3e35 100644 --- a/packages/analytics/src/api.ts +++ b/packages/analytics/src/api.ts @@ -16,7 +16,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -//fsdj + import { _getProvider, FirebaseApp, getApp } from '@firebase/app'; import { Analytics, @@ -63,8 +63,6 @@ declare module '@firebase/component' { } } -console.log('hi'); - /** * Returns an {@link Analytics} instance for the given app. * diff --git a/scripts/ci/check_changeset.ts b/scripts/ci/check_changeset.ts index 0a94fc7d3f1..960e0d2e935 100644 --- a/scripts/ci/check_changeset.ts +++ b/scripts/ci/check_changeset.ts @@ -136,7 +136,10 @@ async function main() { await exec(`echo "BLOCKING_FAILURE=false" >> $GITHUB_OUTPUT`); } catch (e) { const error = e as Error; - if (error.message.match('No changesets present')) { + if ( + error.message.match('No changesets present') || + error.message.match('no changesets were found') + ) { await exec(`echo "BLOCKING_FAILURE=false" >> $GITHUB_OUTPUT`); } else { const messageLines = error.message.replace(/🦋 error /g, '').split('\n'); From aeeee365b93d1af2125af30d009147a8af5caae6 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Wed, 24 Jul 2024 15:03:10 -0700 Subject: [PATCH 3/3] update actions versions --- .github/workflows/check-changeset.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check-changeset.yml b/.github/workflows/check-changeset.yml index ca76fe7a76b..6480477e9bb 100644 --- a/.github/workflows/check-changeset.yml +++ b/.github/workflows/check-changeset.yml @@ -54,14 +54,14 @@ jobs: - name: Print blocking failure status run: echo "${{steps.check-changeset.outputs.BLOCKING_FAILURE}}" - name: Find Comment - uses: peter-evans/find-comment@v1 + uses: peter-evans/find-comment@v3 id: fc with: issue-number: ${{github.event.number}} body-includes: Changeset File Check - name: Create comment (missing packages) if: ${{!steps.fc.outputs.comment-id && steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}} - uses: peter-evans/create-or-update-comment@v1 + uses: peter-evans/create-or-update-comment@v4 with: issue-number: ${{github.event.number}} body: | @@ -69,7 +69,7 @@ jobs: ${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}} - name: Update comment (missing packages) if: ${{steps.fc.outputs.comment-id}} - uses: peter-evans/create-or-update-comment@v1 + uses: peter-evans/create-or-update-comment@v4 with: comment-id: ${{steps.fc.outputs.comment-id}} && steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}} edit-mode: replace @@ -78,7 +78,7 @@ jobs: ${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}} - name: Update comment (no missing packages) if: ${{steps.fc.outputs.comment-id && !steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}} - uses: peter-evans/create-or-update-comment@v1 + uses: peter-evans/create-or-update-comment@v4 with: comment-id: ${{steps.fc.outputs.comment-id}} edit-mode: replace