From e9e26c5ff40d5e0ec975a2abff4f415445b42c80 Mon Sep 17 00:00:00 2001 From: a-maurice Date: Wed, 8 Jun 2022 14:28:19 -0700 Subject: [PATCH] Remove assert when passing null to instance manager --- app/src/cpp_instance_manager.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/src/cpp_instance_manager.h b/app/src/cpp_instance_manager.h index 0d0b0ef37..9609b3de4 100644 --- a/app/src/cpp_instance_manager.h +++ b/app/src/cpp_instance_manager.h @@ -85,11 +85,9 @@ class CppInstanceManager { CppInstanceManager& operator=(CppInstanceManager&&) = delete; /// @brief Increase the reference count by 1. - /// @return Reference count after increment. + /// @return Reference count after increment. Return -1 if invalid instance. int AddReference(InstanceClass* instance) { - FIREBASE_DEV_ASSERT_MESSAGE(instance, - "Null pointer is passed to AddReference<%s>().", - typeid(InstanceClass).name()); + if (!instance) return -1; MutexLock lock(manager_mutex_); auto it = container_.find(instance); if (it != container_.end()) {