Remove deprecated firebase-core dependency (#1417)

kroikie · web-flow · commit d6c93b080d13 · 2019-11-12T16:28:11.000-08:00
* Remove deprecated firebase-core dependency
diff --git a/packages/firebase_core/CHANGELOG.md b/packages/firebase_core/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.4.1+5
+
+* Remove deprecated [firebase-core](https://firebase.google.com/support/release-notes/android) dependency.
+
 ## 0.4.1+4
 
 * Remove visibleForTesting annotation from FirebaseApp constructor. 
diff --git a/packages/firebase_core/android/build.gradle b/packages/firebase_core/android/build.gradle
@@ -32,7 +32,6 @@ android {
         disable 'InvalidPackage'
     }
     dependencies {
-        api 'com.google.firebase:firebase-core:16.0.9'
         implementation 'com.google.firebase:firebase-common:16.1.0'
     }
 }
@@ -55,9 +54,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
-                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
-                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
+                implementation "android.arch.lifecycle:runtime:$lifecycle_version"
+                implementation "android.arch.lifecycle:common:$lifecycle_version"
+                implementation "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/firebase_core/pubspec.yaml b/packages/firebase_core/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Core, enabling connecting to multiple
   Firebase apps.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_core
-version: 0.4.1+4
+version: 0.4.1+5
 
 flutter:
   plugin:

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ android {`
`32`	`32`	`disable 'InvalidPackage'`
`33`	`33`	`}`
`34`	`34`	`dependencies {`
`35`		`- api 'com.google.firebase:firebase-core:16.0.9'`
`36`	`35`	`implementation 'com.google.firebase:firebase-common:16.1.0'`
`37`	`36`	`}`
`38`	`37`	`}`
`@@ -55,9 +54,9 @@ afterEvaluate {`
`55`	`54`	`android {`
`56`	`55`	`dependencies {`
`57`	`56`	`def lifecycle_version = "1.1.1"`
`58`		`- compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"`
`59`		`- compileOnly "android.arch.lifecycle:common:$lifecycle_version"`
`60`		`- compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"`
	`57`	`+ implementation "android.arch.lifecycle:runtime:$lifecycle_version"`
	`58`	`+ implementation "android.arch.lifecycle:common:$lifecycle_version"`
	`59`	`+ implementation "android.arch.lifecycle:common-java8:$lifecycle_version"`
`61`	`60`	`}`
`62`	`61`	`}`
`63`	`62`	`}`