Skip to content

[firebase_auth] Make auth errors uniform and platform independent #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NoamDev opened this issue Aug 25, 2019 · 4 comments
Closed

[firebase_auth] Make auth errors uniform and platform independent #24

NoamDev opened this issue Aug 25, 2019 · 4 comments
Labels
plugin: auth resolution: duplicate This issue or pull request already exists type: enhancement New feature or request

Comments

@NoamDev
Copy link
Contributor

NoamDev commented Aug 25, 2019

It's annoying that for every PlatformException being thrown from firebase auth I have to compare the code twice, once for android and once for ios.

Is it possible to use the same error code in all platforms?
@collinjackson
Copy link
Contributor

I agree that this would be a welcome improvement. I don't have the bandwidth to implement this in the short term but would be happy to review PRs.

@collinjackson collinjackson changed the title Make Firebase auth errors uniform and platform independent [firebase_auth] Make auth errors uniform and platform independent Aug 25, 2019
@NoamDev
Copy link
Contributor Author

NoamDev commented Aug 26, 2019

I've found a list of all error codes (https://docs.google.com/spreadsheets/d/1FDn0rRRYjgXMwc_FIAxO7_cQh69q5VXgQt7Hmvyb1Sg)
in this PR flutter/plugins#775.

@NoamDev
Copy link
Contributor Author

NoamDev commented Aug 26, 2019

I'm not sure if I can do that, but anyway, we should have a specification for it.
which error code and message do we want, the android or the ios version.

@urbanjagodic urbanjagodic mentioned this issue Sep 9, 2019
Closed
@YonatanAmitzur YonatanAmitzur mentioned this issue Sep 16, 2019
Closed
@BondarenkoStas BondarenkoStas added the type: enhancement New feature or request label Sep 23, 2019
@exilonX exilonX mentioned this issue Oct 16, 2019
Closed
@kroikie kroikie mentioned this issue Oct 21, 2019
Closed
@agnoam agnoam mentioned this issue Oct 23, 2019
Closed
@Parmendrakumar Parmendrakumar mentioned this issue Nov 5, 2019
Closed
@PrismaSoftGC PrismaSoftGC mentioned this issue Nov 5, 2019
Closed
@IvanOnishchenko IvanOnishchenko mentioned this issue Nov 6, 2019
Closed
@habtish1 habtish1 mentioned this issue Nov 7, 2019
Closed
@Sonderman Sonderman mentioned this issue Nov 18, 2019
Closed
@amitverma-cf amitverma-cf mentioned this issue Nov 18, 2019
Closed
@boylenssen boylenssen mentioned this issue Nov 20, 2019
Closed
@fabianogadenz fabianogadenz mentioned this issue Nov 20, 2019
Closed
@emailsubjekt emailsubjekt mentioned this issue Dec 9, 2019
Closed
@NickM-27 NickM-27 mentioned this issue Dec 12, 2019
Closed
@jcvw75 jcvw75 mentioned this issue Dec 13, 2019
Closed
@sgehrman sgehrman mentioned this issue Dec 17, 2019
Closed
@yousaywhat yousaywhat mentioned this issue Dec 23, 2019
Closed
@monkeyidesign monkeyidesign mentioned this issue Dec 25, 2019
Closed
@ziasultan2 ziasultan2 mentioned this issue Jan 1, 2020
Closed
@emailsubjekt emailsubjekt mentioned this issue Jan 2, 2020
Closed
@callumclift callumclift mentioned this issue Jan 10, 2020
Closed
@Bharavi26 Bharavi26 mentioned this issue Jan 28, 2020
Closed
@craigbennett1981 craigbennett1981 mentioned this issue Jan 28, 2020
Closed
@trqalothman trqalothman mentioned this issue Jan 30, 2020
Closed
@peterkuch peterkuch mentioned this issue Mar 22, 2020
Closed
@mudi256 mudi256 mentioned this issue Mar 23, 2020
Closed
@shojaeddin shojaeddin mentioned this issue Apr 3, 2020
Closed
@YohanWadia YohanWadia mentioned this issue Apr 3, 2020
Closed
@aliheader aliheader mentioned this issue Apr 3, 2020
Closed
@vineetpandit90 vineetpandit90 mentioned this issue Apr 17, 2020
Closed
@ishtms ishtms mentioned this issue Apr 17, 2020
Closed
@Salakar
Copy link
Member

Salakar commented Apr 21, 2020

Consolidating under #1456 - we'll be looking at parsing native error messages & codes and bubbling these up to the Dart layer in a consistent cross-platform format.

@Salakar Salakar closed this as completed Apr 21, 2020
@Salakar Salakar added plugin: auth resolution: duplicate This issue or pull request already exists labels Apr 21, 2020
@HEMANT96 HEMANT96 mentioned this issue Apr 22, 2020
Closed
@zameerhossain zameerhossain mentioned this issue Apr 28, 2020
Closed
@YashMobileFirst YashMobileFirst mentioned this issue Apr 28, 2020
Closed
@navigui navigui mentioned this issue Apr 30, 2020
Closed
@besidesordinary besidesordinary mentioned this issue May 5, 2020
Closed
@sunilcoder36 sunilcoder36 mentioned this issue May 6, 2020
Closed
@Niccolohui Niccolohui mentioned this issue May 8, 2020
Closed
@clus90 clus90 mentioned this issue May 8, 2020
Closed
@momo1606 momo1606 mentioned this issue Jun 2, 2020
Closed
@aislingorg aislingorg mentioned this issue Jun 3, 2020
Closed
@MassiveSuccess MassiveSuccess mentioned this issue Jun 7, 2020
Closed
@kartikpateldev kartikpateldev mentioned this issue Jun 8, 2020
Closed
@bytejutsu bytejutsu mentioned this issue Jun 12, 2020
Closed
@sumanthkumarps sumanthkumarps mentioned this issue Jul 5, 2020
Closed
@lukaszciastko lukaszciastko mentioned this issue Jul 11, 2020
Closed
@hitanshu1 hitanshu1 mentioned this issue Aug 12, 2020
Closed
@giorodri0584 giorodri0584 mentioned this issue Aug 12, 2020
Closed
@itssidhere itssidhere mentioned this issue Aug 18, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
plugin: auth resolution: duplicate This issue or pull request already exists type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@collinjackson @Salakar @BondarenkoStas @NoamDev