From ed1ef0c4541dba5e08ce13a9760957df597a7b94 Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Tue, 27 Oct 2020 17:57:42 +0530 Subject: [PATCH 1/4] update the readme.md file of firebase_messaging --- packages/firebase_messaging/README.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/packages/firebase_messaging/README.md b/packages/firebase_messaging/README.md index 14313e6b489e..016897f9c317 100644 --- a/packages/firebase_messaging/README.md +++ b/packages/firebase_messaging/README.md @@ -83,17 +83,18 @@ By default background messaging is not enabled. To handle messages in the backgr import io.flutter.plugin.common.PluginRegistry.PluginRegistrantCallback; import io.flutter.plugins.GeneratedPluginRegistrant; import io.flutter.plugins.firebasemessaging.FlutterFirebaseMessagingService; - + import io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin; + public class Application extends FlutterApplication implements PluginRegistrantCallback { - @Override - public void onCreate() { - super.onCreate(); - FlutterFirebaseMessagingService.setPluginRegistrant(this); + @Override + public void onCreate() { + super.onCreate(); + FlutterFirebaseMessagingService.setPluginRegistrant(this); } - + @Override - public void registerWith(PluginRegistry registry) { - GeneratedPluginRegistrant.registerWith(registry); + public void registerWith(PluginRegistry registry) { + FirebaseMessagingPlugin.registerWith(registry.registrarFor("io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin")); } } ``` From c02bc53a0d20191c42fc3adf475898a1c70b63fa Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Tue, 27 Oct 2020 18:01:46 +0530 Subject: [PATCH 2/4] formatting code --- packages/firebase_messaging/README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/firebase_messaging/README.md b/packages/firebase_messaging/README.md index 016897f9c317..fa80e524d6a4 100644 --- a/packages/firebase_messaging/README.md +++ b/packages/firebase_messaging/README.md @@ -86,15 +86,15 @@ By default background messaging is not enabled. To handle messages in the backgr import io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin; public class Application extends FlutterApplication implements PluginRegistrantCallback { - @Override - public void onCreate() { - super.onCreate(); - FlutterFirebaseMessagingService.setPluginRegistrant(this); + @Override + public void onCreate() { + super.onCreate(); + FlutterFirebaseMessagingService.setPluginRegistrant(this); } @Override - public void registerWith(PluginRegistry registry) { - FirebaseMessagingPlugin.registerWith(registry.registrarFor("io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin")); + public void registerWith(PluginRegistry registry) { + FirebaseMessagingPlugin.registerWith(registry.registrarFor("io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin")); } } ``` From 279a8ae9b9aed07801c28d250e1d70e25ba11a98 Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Wed, 28 Oct 2020 14:36:55 +0530 Subject: [PATCH 3/4] refector code --- packages/firebase_messaging/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/firebase_messaging/README.md b/packages/firebase_messaging/README.md index fa80e524d6a4..955de40c0181 100644 --- a/packages/firebase_messaging/README.md +++ b/packages/firebase_messaging/README.md @@ -85,13 +85,14 @@ By default background messaging is not enabled. To handle messages in the backgr import io.flutter.plugins.firebasemessaging.FlutterFirebaseMessagingService; import io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin; + public class Application extends FlutterApplication implements PluginRegistrantCallback { @Override public void onCreate() { super.onCreate(); FlutterFirebaseMessagingService.setPluginRegistrant(this); } - + @Override public void registerWith(PluginRegistry registry) { FirebaseMessagingPlugin.registerWith(registry.registrarFor("io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin")); From 0ba29047e87255f21b6800e857b7495e845e534e Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Sun, 1 Nov 2020 14:12:40 +0530 Subject: [PATCH 4/4] removed GeneratedPluginRegistrant imports --- packages/firebase_messaging/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/firebase_messaging/README.md b/packages/firebase_messaging/README.md index 955de40c0181..cd63c1bd6a5e 100644 --- a/packages/firebase_messaging/README.md +++ b/packages/firebase_messaging/README.md @@ -81,7 +81,6 @@ By default background messaging is not enabled. To handle messages in the backgr import io.flutter.app.FlutterApplication; import io.flutter.plugin.common.PluginRegistry; import io.flutter.plugin.common.PluginRegistry.PluginRegistrantCallback; - import io.flutter.plugins.GeneratedPluginRegistrant; import io.flutter.plugins.firebasemessaging.FlutterFirebaseMessagingService; import io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin;