Skip to content

Commit 109fe56

Browse files
committed
refactor: delete extra uiState
1 parent c52e1b5 commit 109fe56

File tree

1 file changed

+5
-6
lines changed
  • dataconnect/app/src/main/java/com/google/firebase/example/dataconnect/feature/actordetail

1 file changed

+5
-6
lines changed

dataconnect/app/src/main/java/com/google/firebase/example/dataconnect/feature/actordetail/ActorDetailScreen.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,9 @@ fun ActorDetailScreen(
6363
when (uiState) {
6464
is ActorDetailUIState.Error -> ErrorCard(uiState.errorMessage)
6565

66-
ActorDetailUIState.Loading -> LoadingScreen()
66+
is ActorDetailUIState.Loading -> LoadingScreen()
6767

6868
is ActorDetailUIState.Success -> {
69-
val ui = uiState
7069
Scaffold { innerPadding ->
7170
val scrollState = rememberScrollState()
7271
Column(
@@ -75,21 +74,21 @@ fun ActorDetailScreen(
7574
.verticalScroll(scrollState)
7675
) {
7776
ActorInformation(
78-
actor = ui.actor,
79-
isActorFavorite = ui.isFavorite,
77+
actor = uiState.actor,
78+
isActorFavorite = uiState.isFavorite,
8079
onFavoriteToggled = onFavoriteToggled
8180
)
8281
MoviesList(
8382
listTitle = stringResource(R.string.title_main_roles),
84-
movies = ui.actor?.mainActors?.mapNotNull {
83+
movies = uiState.actor?.mainActors?.mapNotNull {
8584
Movie(it.id.toString(), it.imageUrl, it.title)
8685
},
8786
onMovieClicked = onMovieClicked
8887
)
8988
Spacer(modifier = Modifier.height(8.dp))
9089
MoviesList(
9190
listTitle = stringResource(R.string.title_supporting_actors),
92-
movies = ui.actor?.supportingActors?.mapNotNull {
91+
movies = uiState.actor?.supportingActors?.mapNotNull {
9392
Movie(it.id.toString(), it.imageUrl, it.title)
9493
},
9594
onMovieClicked = onMovieClicked

0 commit comments

Comments
 (0)