Fixed a bunch of whitespace errors

Fixed a bunch of whitespace errors scattered throughout the repo.

Signed-off-by: Dan Horobeanu <[email protected]>

Author: dhrgit

.github/pull_request_template.md

@@ -13,12 +13,12 @@ the terms of the Apache 2.0 license.
 
 ## PR Checklist
 
-`[Author TODO: Meet these criteria. Where there are two options, keep one.]`  
+`[Author TODO: Meet these criteria. Where there are two options, keep one.]`
 `[Reviewer TODO: Verify that these criteria are met. Request changes if not]`
 
 - [ ] All commits in this PR are signed (`git commit -s`).
 - [ ] Either this PR is linked to an issue, or, the reason for this PR is
-      clearly provided. 
+      clearly provided.
 - [ ] The description of changes is clear and encompassing.
 - [ ] Either no docs need to be updated as part of this PR, or, the required
       doc changes are included in this PR. Docs in scope are all `*.md` files

CODE_OF_CONDUCT.md

@@ -3,6 +3,6 @@
 This project has adopted the
 [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
 For more information see the
-[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact 
+[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
 [[email protected]](mailto:[email protected])
 with any additional questions or comments.

CONTRIBUTING.md

@@ -23,7 +23,7 @@ commit-based feedback for a contribution, follow the
 Firecracker uses the “fork-and-pull” development model. Follow these steps if
 you want to merge your changes to Firecracker:
 
-1. Within your fork of 
+1. Within your fork of
    [Firecracker](https://github.com/firecracker-microvm/firecracker), create a
    branch for your contribution. Use a meaningful name.
 1. Create your contribution, meeting all
@@ -43,7 +43,7 @@ you want to merge your changes to Firecracker:
 If you just want to receive feedback for a contribution proposal, open an “RFC”
 (“Request for Comments”) pull request:
 
-1. On your fork of 
+1. On your fork of
    [Firecracker](https://github.com/firecracker-microvm/firecracker), create a
    branch for the contribution you want feedback on. Use a meaningful name.
 1. Create your proposal based on the existing codebase.
@@ -74,4 +74,3 @@ testing. Your contribution needs to meet the following standards:
   part of your contribution contravenes this license by signing off on all your
   commits with `git -s`. Ensure that every file in your pull request has a
   header referring to the repository license file.
-

FAQ.md

@@ -168,7 +168,7 @@ You can see more info about the `refclock` parameters
 [here](https://chrony.tuxfamily.org/doc/3.4/chrony.conf.html#refclock).
 Adjust them according to your needs.
 
-### Each Firecracker opens 20+ file descriptors. Is this an issue?  
+### Each Firecracker opens 20+ file descriptors. Is this an issue?
 
 The relatively high FD usage is expected and correct. Firecracker heavily
 relies on event file descriptors to drive device emulation.
@@ -230,7 +230,7 @@ Possible mitigations are:
 
 ### How can I configure and start a microVM without sending API calls?
 
-Passing an optional command line parameter, `--config-file`, to the Firecracker 
-process allows this type of configuration. This parameter must be the path to a 
-file that contains the JSON specification that will be used to configure and start 
-the microVM. One example of such file can be found at `tests/framework/vm_config.json`. 
+Passing an optional command line parameter, `--config-file`, to the Firecracker
+process allows this type of configuration. This parameter must be the path to a
+file that contains the JSON specification that will be used to configure and start
+the microVM. One example of such file can be found at `tests/framework/vm_config.json`.

MAINTAINERS.md

@@ -9,4 +9,3 @@ Firecracker is maintained by a dedicated team within Amazon:
 - Dan Horobeanu <[email protected]>
 - Diana Popa <[email protected]>
 - Andreea Florescu <[email protected]>
-

NOTICE

@@ -1,2 +1,2 @@
 Firecracker
-Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. 
+Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.

SECURITY-POLICY.md

@@ -20,4 +20,3 @@ vulnerability during the embargo period.
 
 At the end of the embargo period, maintainers will publicly release information
 about the vulnerability together with the Firecracker patches that mitigate it.
-

SPECIFICATION.md

@@ -58,4 +58,3 @@ enough RAM, etc.), customers can rely on the following:
 ³ No logs are currently produced in the span of time between the `jailer`
   process start-up and the logging system initialization in the `firecracker`
   process.
-

docs/dev-machine-setup.md

@@ -63,22 +63,22 @@ Follow these steps to create a bare metal instance.
 
 1. If you don't already have an AWS account, create one using the [AWS Portal](https://portal.aws.amazon.com/billing/signup).
 1. Login to [AWS console](https://console.aws.amazon.com/console/home?region=us-east-1). Bare metal instances are
- only supported in `US East (N. Virginia)` region at this time. This 
+ only supported in `US East (N. Virginia)` region at this time. This
 region is preselected for you in the Console.
 1. Click on `Launch a virtual machine` in `Build Solution` section.
-1. Firecracker requires a relatively new kernel, so you should use a recent 
+1. Firecracker requires a relatively new kernel, so you should use a recent
 Linux distribution - such as `Ubuntu Server 18.04 LTS (HVM), SSD Volume Type`.
 1. In `Step 2`, scroll to the bottom and select `i3.metal` instance type. Click
  on `Next: Configure Instance Details`.
 1. In `Step 3`, click on `Next: Add Storage`.
 1. In `Step 4`, click on `Next: Add Tags`.
 1. In `Step 5`, click on `Next: Configure Security Group`.
-1. In `Step 6`, take the default security group. This opens up port 22 and is 
+1. In `Step 6`, take the default security group. This opens up port 22 and is
 needed so that you can ssh into the machine later. Click on `Review and Launch`.
-1. Verify the details and click on `Launch`. If you do not have an existing 
-key pair, then you can select `Create a new key pair` to create a key pair. 
+1. Verify the details and click on `Launch`. If you do not have an existing
+key pair, then you can select `Create a new key pair` to create a key pair.
 This is needed so that you can use it later to ssh into the machine.
-1. Click on the instance id in the green box. Copy `Public DNS` from the 
+1. Click on the instance id in the green box. Copy `Public DNS` from the
 `Description` tab of the selected instance.
 1. Login to the newly created instance:
 
@@ -99,7 +99,7 @@ you can find brief instructions in the Addendum [below](#addendum).
 Here is a brief summary of steps to create such a setup (full instructions to
 set up a Ubuntu-based VM on GCE with nested KVM enablement can be found in GCE
 [documentation](https://cloud.google.com/compute/docs/instances/enable-nested-virtualization-vm-instances)).
- 
+
   1. Select a GCP project and zone
 
      ```
@@ -113,19 +113,19 @@ set up a Ubuntu-based VM on GCE with nested KVM enablement can be found in GCE
      It might be convenient to keep your Firecracker-related GCP resources in
      a separate project, so that you can keep track of resources more easily
      and remove everything easily once your are done.
-     
-     For convenience, give the project a unique name (e.g., 
+
+     For convenience, give the project a unique name (e.g.,
      your_name-firecracker), so that GCP does not need to create a project
      id different than project name (by appending randomized numbers to the
      name you provide).
- 
+
      ```
      $ gcloud projects create ${FC_PROJECT} --enable-cloud-apis --set-as-default
      ```
 
      </p>
      </details>
-     
+
      ```
      $ gcloud config set project ${FC_PROJECT}
      $ gcloud config set compute/region ${FC_REGION}
@@ -134,7 +134,7 @@ set up a Ubuntu-based VM on GCE with nested KVM enablement can be found in GCE
 
   1. The next step is to create a VM image able to run nested KVM (as outlined
      [here](https://cloud.google.com/compute/docs/instances/enable-nested-virtualization-vm-instances)).
-     
+
      **IMPORTANT:** Notice that Firecracker requires a relatively new kernel,
      so you should use a recent Linux distribution image - such as Ubuntu 18
      (used in the commands below), or equivalent.
@@ -157,19 +157,19 @@ set up a Ubuntu-based VM on GCE with nested KVM enablement can be found in GCE
         --image ${FC_IMAGE}
      ```
 
-  1. Connect to the VM via SSH.  
+  1. Connect to the VM via SSH.
 
      ```
      $ gcloud compute ssh ${FC_VM}
      ```
 
      When doing it for the first time, a key-pair will be created for you
      (you will be propmpted for a passphrase - can just keep it empty) and
-     uploaded to GCE. Done! You should see the prompt of the new VM: 
+     uploaded to GCE. Done! You should see the prompt of the new VM:
 
      ```
      ubuntu@firecracker-vm:~$
-     ```  
+     ```
 
   1. Verify that VMX is enabled, enable KVM
 
@@ -180,7 +180,7 @@ set up a Ubuntu-based VM on GCE with nested KVM enablement can be found in GCE
      $ [ -r /dev/kvm ] && [ -w /dev/kvm ] && echo "OK" || echo "FAIL"
      OK
      ```
-  
+
   Now you can continue with the Firecracker [Getting Started](getting-started.md)
   instructions to install and configure Firecracker in the new VM.
 
@@ -194,7 +194,7 @@ In a nutshell, setting up a GCP account involves the following steps:
   Google credentials. If you don't have account, you will be prompted to join
   the trial.
 
-  1. Install GCP CLI & SDK (full instructions can be found 
+  1. Install GCP CLI & SDK (full instructions can be found
   [here](https://cloud.google.com/sdk/docs/quickstart-debian-ubuntu))
 
      ```
@@ -203,7 +203,7 @@ In a nutshell, setting up a GCP account involves the following steps:
        | sudo tee -a /etc/apt/sources.list.d/google-cloud-sdk.list
      $ curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add -
      $ sudo apt-get update && sudo apt-get install -y google-cloud-sdk
-     ```        
+     ```
 
   1. Configure the `gcloud` CLI by running:
 
@@ -217,4 +217,3 @@ In a nutshell, setting up a GCP account involves the following steps:
 ### Microsoft Azure
 
 `[TODO]`
-

docs/getting-started.md

@@ -247,24 +247,24 @@ curl --unix-socket /tmp/firecracker.socket -i  \
 
 #### Configuring the microVM without sending API requests
 
-If you'd like to boot up a guest machine without using the API socket, you can do that 
-by passing the parameter `--config-file` to the Firecracker process. The command for 
+If you'd like to boot up a guest machine without using the API socket, you can do that
+by passing the parameter `--config-file` to the Firecracker process. The command for
 starting Firecracker with this option will look like this:
 
 ```bash
-./firecracker --api-sock /tmp/firecracker.socket --config-file 
+./firecracker --api-sock /tmp/firecracker.socket --config-file
 <path_to_the_configuration_file>
-```    
-
-`path_to_the_configuration_file` should represent the path to a file that contains a 
-JSON which stores the entire configuration for all of the microVM's resources. The 
-JSON **must** contain the configuration for the guest kernel and rootfs, as these 
-are mandatory, but all of the other resources are optional, so it's your choice 
-if you want to configure them or not. Because using this configuration method will 
-also start the microVM, you need to specify all desired pre-boot configurable resources 
-in that JSON. The names of the resources are the ones from the `firecracker.yaml` file 
-and the names of their fields are the same that are used in API requests. 
-You can find an example of configuration file at `tests/framework/vm_config.json`. 
+```
+
+`path_to_the_configuration_file` should represent the path to a file that contains a
+JSON which stores the entire configuration for all of the microVM's resources. The
+JSON **must** contain the configuration for the guest kernel and rootfs, as these
+are mandatory, but all of the other resources are optional, so it's your choice
+if you want to configure them or not. Because using this configuration method will
+also start the microVM, you need to specify all desired pre-boot configurable resources
+in that JSON. The names of the resources are the ones from the `firecracker.yaml` file
+and the names of their fields are the same that are used in API requests.
+You can find an example of configuration file at `tests/framework/vm_config.json`.
 After the machine is booted, you can still use the socket to send API requests
 for post-boot operations.
 
@@ -302,10 +302,10 @@ Within the Firecracker repository root directory:
 
 This will build and place the two Firecracker binaries at:
 - `build/cargo_target/${toolchain}/debug/firecracker` and
-- `build/cargo_target/${toolchain}/debug/jailer`. 
+- `build/cargo_target/${toolchain}/debug/jailer`.
 
-The default build profile is `debug`. If you want to build 
-the release binaries (optimized and stripped of debug info), 
+The default build profile is `debug`. If you want to build
+the release binaries (optimized and stripped of debug info),
 use the `--release` option:
 
 ```bash

docs/jailer.md

@@ -39,13 +39,13 @@ jailer --id <id> \
     Firecracker.
   - 2 (default): advanced filtering. This adds further checks on some of the
     parameters of the allowed syscalls.
-- The jailer adheres to the "end of command options" convention, meaning 
-  all parameters specified after `--` are forwarded to Firecracker. For 
-  example, this can be paired with the `--config-file` Firecracker argument to 
-  specify a configuration file when starting Firecracker via the jailer (the 
-  file path and the resources referenced within must be valid relative to a 
-  jailed Firecracker). Please note the jailer already passes the following 
-  parameters to the Firecracker process: `--api-sock`, `--seccomp-level` and 
+- The jailer adheres to the "end of command options" convention, meaning
+  all parameters specified after `--` are forwarded to Firecracker. For
+  example, this can be paired with the `--config-file` Firecracker argument to
+  specify a configuration file when starting Firecracker via the jailer (the
+  file path and the resources referenced within must be valid relative to a
+  jailed Firecracker). Please note the jailer already passes the following
+  parameters to the Firecracker process: `--api-sock`, `--seccomp-level` and
   `--id`.
 
 ## Jailer Operation

docs/mmds.md

@@ -7,8 +7,8 @@ the data store, and the minimalist HTTP/TCP/IPv4 stack (named *Dumbo*). They
 all exist within the Firecracker process, and outside the KVM boundary; the
 first is a part of the API server, the data store is a global entity for a
 single microVM, and the last is a part of the device model.
-When the API server is disabled by passing `--no-api` parameter to Firecracker, 
-MMDS is no longer available. 
+When the API server is disabled by passing `--no-api` parameter to Firecracker,
+MMDS is no longer available.
 
 ## The MMDS backend
 

docs/rootfs-and-kernel-setup.md

@@ -17,26 +17,26 @@ can boot:
    git clone https://github.com/torvalds/linux.git linux.git
    cd linux.git
    ```
-   
+
 2. Check out the Linux version you want to build (e.g. we'll be using v4.20
    here):
-   
+
    ```bash
    git checkout v4.20
    ```
-   
+
 3. You will need to configure your Linux build. You can start from
    [our recommended config](../resources/microvm-kernel-config) - just copy
    it to `.config` (under the Linux sources dir). You can make interactive
    config adjustments using:
-   
+
    ```bash
    make menuconfig
    ```
-   
+
    *Note*: there are many ways of building a kernel config file, other than
    `menuconfig`. You are free to use whichever one you choose.
-   
+
 4. Build the uncompressed kernel image:
 
    ```bash
@@ -58,11 +58,11 @@ at boot time.
 To build an EXT4 image:
 1. Prepare a properly-sized file. We'll use 50MiB here, but this depends
    on how much data you'll want to fit inside:
-   
+
    ```bash
    dd if=/dev/zero of=/rootfs.ext4 bs=1M count=50
    ```
-   
+
 2. Create an empty file system on the file you created:
 
    ```bash
@@ -109,12 +109,12 @@ Alpine Linux:
    ln -s agetty /etc/init.d/agetty.ttyS0
    echo ttyS0 > /etc/securetty
    rc-update add agetty.ttyS0 default
-  
+
    # Make sure special file systems are mounted on boot:
    rc-update add devfs boot
    rc-update add procfs boot
    rc-update add sysfs boot
-  
+
    # Then, copy the newly configured system to the rootfs image:
    for d in bin etc lib root sbin usr; do tar c "/$d" | tar x -C /my-rootfs; done
    for dir in dev proc run sys var; do mkdir /my-rootfs/${dir}; done
@@ -131,4 +131,3 @@ Alpine Linux:
 
 You should now have a kernel image (`vmlinux`) and a rootfs image
 (`rootfs.ext4`), that you can boot with Firecracker.
-

docs/vsock.md

@@ -22,7 +22,7 @@ The Firecracker vsock device aims to provide full virtio-vsock support to
 software running inside the guest VM, while bypassing vhost kernel code on the
 host. To that end, Firecracker implements the virtio-vsock device model, and
 mediates communication between AF_UNIX sockets (on the host end) and AF_VSOCK
-sockets (on the guest end). 
+sockets (on the guest end).
 
 In order to provide channel multiplexing, AF_VSOCK ports are translated into
 multiple AF_UNIX sockets (one Unix socket per vsock port). The virtio-vsock

src/arch_gen/Cargo.toml

@@ -4,4 +4,3 @@ version = "0.1.0"
 authors = ["Amazon Firecracker team <[email protected]>"]
 
 [dependencies]
-

src/virtio_gen/patches/0001-virtio_gen-remove-derive-Debug-from-packed-struct.patch

@@ -26,6 +26,5 @@ index 0b68d09..a1c9dca 100644
  pub struct virtio_net_ctrl_mac {
      pub entries: __virtio32,
      pub macs: __IncompleteArrayField<[__u8; 6usize]>,
--- 
+--
 2.7.4
-