Merge branch 'master' into app_shared_pkg_web

Author: kevmoo

.github/workflows/build.yaml

@@ -52,6 +52,7 @@ jobs:
           - build_dart2js
           - test_ddc
           - test_dart2js
+          - benchmarks_dart2js
     steps:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac

.github/workflows/flutter-candidate-update.yaml

@@ -3,7 +3,7 @@ on:
   workflow_dispatch: # Allows for manual triggering if needed
   schedule:
     # * is a special character in YAML so you have to quote this string
-    - cron: "0 8 * * *" # Run every day at midnight Pacific Time
+    - cron: "0 8/12 * * *" # Run every day at midnight and noon Pacific Time
 
 permissions:
   contents: write

CONTRIBUTING.md

@@ -84,7 +84,7 @@ of launch configurations for running and debugging DevTools:
 
 ### Workflow for making changes
 
-1. Change your local Flutter SDK to the latest flutter candidate branch: `./tool/update_flutter_sdk.sh --local`
+1. Change your local Flutter SDK to the latest flutter candidate branch: `devtools_tool update-flutter-sdk --local`
 2. Create a branch from your cloned DevTools repo: `git checkout -b myBranch`
 3. Ensure your branch, dependencies, and generated code are up-to-date: `devtools_tool sync`
 4. Implement your changes, and commit to your branch: `git commit -m “description”`

case_study/memory_leaks/memory_leak_app/pubspec.yaml

@@ -11,7 +11,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  intl: '>=0.16.1 <0.19.0'
+  intl: ^0.18.0
   http: ^0.13.5
 
 # For information on the generic Dart part of this file, see the

flutter-candidate.txt

@@ -1 +1 @@
-3.16.0-16.0.pre
+3.16.0-17.0.pre

packages/devtools_app/lib/devtools_app.dart

@@ -57,6 +57,7 @@ export 'src/service/json_to_service_cache.dart';
 export 'src/service/resolved_uri_manager.dart';
 export 'src/service/service_extensions.dart';
 export 'src/service/service_manager.dart';
+export 'src/service/service_registrations.dart';
 export 'src/service/timeline_streams.dart';
 export 'src/service/vm_flags.dart';
 export 'src/service/vm_service_wrapper.dart';

packages/devtools_app/lib/src/screens/performance/panes/frame_analysis/frame_hints.dart

@@ -370,10 +370,10 @@ class ShaderCompilationHint extends StatelessWidget {
                 LinkTextSpan(
                   link: Link(
                     display: 'Impeller',
-                    url: impellerWikiUrl,
+                    url: impellerDocsUrl,
                     gaScreenName: gac.performance,
                     gaSelectedItemDescription:
-                        gac.PerformanceDocs.impellerWikiLink.name,
+                        gac.PerformanceDocs.impellerDocsLink.name,
                   ),
                   context: context,
                 ),

packages/devtools_app/lib/src/screens/performance/panes/raster_stats/raster_stats.dart

@@ -14,19 +14,48 @@ import '../../../../shared/globals.dart';
 import '../../../../shared/primitives/utils.dart';
 import '../../../../shared/table/table.dart';
 import '../../../../shared/table/table_data.dart';
+import '../../performance_utils.dart';
 import 'raster_stats_controller.dart';
 import 'raster_stats_model.dart';
 
 class RasterStatsView extends StatelessWidget {
   const RasterStatsView({
     super.key,
     required this.rasterStatsController,
+    required this.impellerEnabled,
   });
 
   final RasterStatsController rasterStatsController;
 
+  final bool impellerEnabled;
+
   @override
   Widget build(BuildContext context) {
+    if (impellerEnabled) {
+      return Center(
+        child: RichText(
+          textAlign: TextAlign.center,
+          text: TextSpan(
+            text: 'The Raster Stats tool is not currently available for the '
+                'Impeller backend.\nLearn more about the status of ',
+            style: Theme.of(context).regularTextStyle,
+            children: [
+              LinkTextSpan(
+                link: Link(
+                  display: 'Impeller',
+                  url: impellerDocsUrl,
+                  gaScreenName: gac.performance,
+                  gaSelectedItemDescription:
+                      gac.PerformanceDocs.impellerDocsLinkFromRasterStats.name,
+                ),
+                context: context,
+              ),
+              const TextSpan(text: '.'),
+            ],
+          ),
+        ),
+      );
+    }
     return Column(
       children: [
         if (!offlineController.offlineMode.value)

packages/devtools_app/lib/src/screens/performance/panes/raster_stats/raster_stats_controller.dart

@@ -41,6 +41,10 @@ class RasterStatsController extends PerformanceFeatureController {
       setData(rasterStats);
     } catch (e, st) {
       _log.shout('Error collecting raster stats: $e', e, st);
+      notificationService.pushError(
+        'Error collecting raster stats: $e',
+        stackTrace: st.toString(),
+      );
       clearData();
     } finally {
       _loadingSnapshot.value = false;

packages/devtools_app/lib/src/screens/performance/performance_controller.dart

@@ -7,6 +7,7 @@ import 'dart:async';
 import 'package:devtools_app_shared/utils.dart';
 import 'package:vm_service/vm_service.dart';
 
+import '../../service/service_registrations.dart' as registrations;
 import '../../shared/diagnostics/inspector_service.dart';
 import '../../shared/feature_flags.dart';
 import '../../shared/globals.dart';
@@ -98,6 +99,9 @@ class PerformanceController extends DisposableController
   /// in selected timeline event, selected frame, etc.).
   PerformanceData? offlinePerformanceData;
 
+  bool get impellerEnabled => _impellerEnabled;
+  late final bool _impellerEnabled;
+
   final _initialized = Completer<void>();
 
   Future<void> get initialized => _initialized.future;
@@ -115,6 +119,17 @@ class PerformanceController extends DisposableController
     if (!offlineController.offlineMode.value) {
       await serviceConnection.serviceManager.onServiceAvailable;
 
+      if (serviceConnection.serviceManager.connectedApp?.isFlutterAppNow ??
+          false) {
+        final impellerEnabledResponse = await serviceConnection.serviceManager
+            .callServiceExtensionOnMainIsolate(
+          registrations.isImpellerEnabled,
+        );
+        _impellerEnabled = impellerEnabledResponse.json?['enabled'] == true;
+      } else {
+        _impellerEnabled = false;
+      }
+
       enhanceTracingController.init();
 
       // Listen for Flutter.Frame events with frame timing data.