Skip to content

Add a regression test for DevTools extensions connecting to Dart CLI apps #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenzieschmoll opened this issue Dec 20, 2023 · 2 comments
Assignees
Labels
devtools extensions Issues related to DevTools extensions P2 important to work on, but not at the top of the work list. testing

Comments

@kenzieschmoll
Copy link
Member

Fix was here: #6993.

To add testing for this, we need to add an integration test that spawns a Dart CLI app and connects to DevTools to load extensions. Our current test coverage just tests a Flutter app.

@kenzieschmoll kenzieschmoll added testing devtools extensions Issues related to DevTools extensions P2 important to work on, but not at the top of the work list. labels Dec 20, 2023
@kenzieschmoll kenzieschmoll self-assigned this Dec 20, 2023
@srawlins
Copy link
Contributor

srawlins commented May 2, 2025

@kenzieschmoll I see one integration test at packages/devtools_extensions/integration_test (simulated_environment_test.dart). Is this where we should add this new integration test? It looks like we could use the same TestDevToolsExtension, and just test it against a different app, a Dart app?

I can't actually find what app it is testing against. Is that sort of the new code we need? Does "simulated environment" mean "no app" 😅 ?

@kenzieschmoll
Copy link
Member Author

I think we'd actually want to add another test like this one: https://github.com/flutter/devtools/blob/master/packages/devtools_app/integration_test/test/live_connection/devtools_extensions_test.dart. However, we first need to address this issue (#7748) which would add support for our integration tests to actually start the DevTools server. We added support for running a debug build of DevTools with the server here: #6486, but this may need some work to wire up to the integration testing framework since it expects DevTools to be able to run with Flutter driver. It should be possible though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools extensions Issues related to DevTools extensions P2 important to work on, but not at the top of the work list. testing
Projects
None yet
Development

No branches or pull requests

2 participants