hide FlutterTextInputView from accessibility

Author: yjbanov

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -517,8 +517,28 @@ - (void)deleteBackward {
 
 @end
 
+/**
+ * Hides `FlutterTextInputView` from iOS accessibility system so it
+ * does not show up twice, once where it is in the `UIView` hierarchy,
+ * and a second time as part of the `SemanticsObject` hierarchy.
+ */
+@interface FlutterTextInputViewAccessibilityHider : UIView {
+}
+
+@end
+
+@implementation FlutterTextInputViewAccessibilityHider {
+}
+
+- (BOOL)accessibilityElementsHidden {
+  return YES;
+}
+
+@end
+
 @implementation FlutterTextInputPlugin {
   FlutterTextInputView* _view;
+  FlutterTextInputViewAccessibilityHider* _inputHider;
 }
 
 @synthesize textInputDelegate = _textInputDelegate;
@@ -528,6 +548,7 @@ - (instancetype)init {
 
   if (self) {
     _view = [[FlutterTextInputView alloc] init];
+    _inputHider = [[FlutterTextInputViewAccessibilityHider alloc] init];
   }
 
   return self;
@@ -536,6 +557,7 @@ - (instancetype)init {
 - (void)dealloc {
   [self hideTextInput];
   [_view release];
+  [_inputHider release];
 
   [super dealloc];
 }
@@ -572,13 +594,15 @@ - (void)showTextInput {
            @"The application must have a key window since the keyboard client "
            @"must be part of the responder chain to function");
   _view.textInputDelegate = _textInputDelegate;
-  [[UIApplication sharedApplication].keyWindow addSubview:_view];
+  [_inputHider addSubview:_view];
+  [[UIApplication sharedApplication].keyWindow addSubview:_inputHider];
   [_view becomeFirstResponder];
 }
 
 - (void)hideTextInput {
   [_view resignFirstResponder];
   [_view removeFromSuperview];
+  [_inputHider removeFromSuperview];
 }
 
 - (void)setTextInputClient:(int)client withConfiguration:(NSDictionary*)configuration {

shell/platform/darwin/ios/framework/Source/accessibility_text_entry.h

@@ -6,7 +6,8 @@
 #define SHELL_PLATFORM_IOS_FRAMEWORK_SOURCE_ACCESSIBILITY_TEXT_ENTRY_H_
 
 /**
- * An implementation of `UITextInput` used for text fields that do not currently have input focus.
+ * An implementation of `UITextInput` used for text fields that do not currently
+ * have input focus.
  *
  * This class is used by `TextInputSemanticsObject`.
  */
@@ -22,10 +23,12 @@
 @end
 
 /**
- * An implementation of `SemanticsObject` specialized for expressing text fields.
+ * An implementation of `SemanticsObject` specialized for expressing text
+ * fields.
  *
- * Delegates to `FlutterTextInputView` when the object corresponds to a text field
- * that currently owns input focus. Delegates to `FlutterInactiveTextInput` otherwise.
+ * Delegates to `FlutterTextInputView` when the object corresponds to a text
+ * field that currently owns input focus. Delegates to
+ * `FlutterInactiveTextInput` otherwise.
  */
 @interface TextInputSemanticsObject : SemanticsObject<UITextInput>
 @end

shell/platform/darwin/ios/framework/Source/accessibility_text_entry.mm

@@ -165,7 +165,6 @@ - (void)deleteBackward {
 
 @end
 
-
 @implementation TextInputSemanticsObject {
   FlutterInactiveTextInput* _inactive_text_input;
 }