Revert "Make fml/... compatible with .clang_tidy. (#47992)"

This reverts commit 3cd830c.

Author: auto-submit[bot]

fml/memory/ref_counted_internal.h

@@ -87,7 +87,8 @@ inline RefCountedThreadSafeBase::RefCountedThreadSafeBase()
     : ref_count_(1u)
 #ifndef NDEBUG
       ,
-      adoption_required_(true)
+      adoption_required_(true),
+      destruction_started_(false)
 #endif
 {
 }

fml/memory/weak_ptr_internal.h

@@ -30,7 +30,7 @@ class WeakPtrFlag : public fml::RefCountedThreadSafe<WeakPtrFlag> {
   void Invalidate();
 
  private:
-  bool is_valid_ = false;
+  bool is_valid_;
 
   FML_DISALLOW_COPY_AND_ASSIGN(WeakPtrFlag);
 };

fml/message_loop_task_queues.h

@@ -155,7 +155,7 @@ class MessageLoopTaskQueues {
   mutable std::mutex queue_mutex_;
   std::map<TaskQueueId, std::unique_ptr<TaskQueueEntry>> queue_entries_;
 
-  size_t task_queue_id_counter_ = 0;
+  size_t task_queue_id_counter_;
 
   std::atomic_int order_;
 

fml/platform/android/message_loop_android.h

@@ -29,7 +29,7 @@ class MessageLoopAndroid : public MessageLoopImpl {
  private:
   fml::UniqueObject<ALooper*, UniqueLooperTraits> looper_;
   fml::UniqueFD timer_fd_;
-  bool running_ = false;
+  bool running_;
 
   MessageLoopAndroid();
 

fml/shared_thread_merger.h

@@ -59,7 +59,7 @@ class SharedThreadMerger
   fml::TaskQueueId subsumed_;
   fml::MessageLoopTaskQueues* task_queues_;
   std::mutex mutex_;
-  bool enabled_ = false;
+  bool enabled_;
 
   /// The |MergeWithLease| or |ExtendLeaseTo| method will record the caller
   /// into this lease_term_by_caller_ map, |UnMergeNowIfLastOne|

fml/synchronization/semaphore.cc

@@ -170,24 +170,24 @@ class PlatformSemaphore {
 
 namespace fml {
 
-Semaphore::Semaphore(uint32_t count) : impl_(new PlatformSemaphore(count)) {}
+Semaphore::Semaphore(uint32_t count) : _impl(new PlatformSemaphore(count)) {}
 
 Semaphore::~Semaphore() = default;
 
 bool Semaphore::IsValid() const {
-  return impl_->IsValid();
+  return _impl->IsValid();
 }
 
 bool Semaphore::Wait() {
-  return impl_->Wait();
+  return _impl->Wait();
 }
 
 bool Semaphore::TryWait() {
-  return impl_->TryWait();
+  return _impl->TryWait();
 }
 
 void Semaphore::Signal() {
-  return impl_->Signal();
+  return _impl->Signal();
 }
 
 }  // namespace fml

fml/synchronization/semaphore.h

@@ -78,7 +78,7 @@ class Semaphore {
   void Signal();
 
  private:
-  std::unique_ptr<PlatformSemaphore> impl_;
+  std::unique_ptr<PlatformSemaphore> _impl;
 
   FML_DISALLOW_COPY_AND_ASSIGN(Semaphore);
 };