Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 48ddaf5

Browse files
authored
Ensure Vulkan when including Skia Vulkan headers (#55126)
Skia is changing how it handles its internal copy of Vulkan headers to prevent them from accidentally leaking to users and potentially overriding the user's Vulkan headers. Users of Skia are responsible for providing the Vulkan headers when including Skia's public Vk headers. This change only includes Skia's public Vk headers when Flutter is providing the Vulkan headers.
1 parent 6c5895a commit 48ddaf5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

shell/platform/embedder/embedder.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "third_party/skia/include/gpu/GpuTypes.h"
2424
#include "third_party/skia/include/gpu/ganesh/GrBackendSurface.h"
2525
#include "third_party/skia/include/gpu/ganesh/SkSurfaceGanesh.h"
26-
#include "third_party/skia/include/gpu/ganesh/vk/GrVkTypes.h"
2726

2827
#if !defined(FLUTTER_NO_EXPORT)
2928
#if FML_OS_WIN
@@ -101,6 +100,7 @@ extern const intptr_t kPlatformStrongDillSize;
101100

102101
#ifdef SHELL_ENABLE_VULKAN
103102
#include "third_party/skia/include/gpu/ganesh/vk/GrVkBackendSurface.h"
103+
#include "third_party/skia/include/gpu/ganesh/vk/GrVkTypes.h"
104104
#endif // SHELL_ENABLE_VULKAN
105105

106106
const int32_t kFlutterSemanticsNodeIdBatchEnd = -1;

shell/platform/embedder/tests/embedder_test_backingstore_producer.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,14 @@
1414
#include "third_party/skia/include/gpu/GpuTypes.h"
1515
#include "third_party/skia/include/gpu/ganesh/GrBackendSurface.h"
1616
#include "third_party/skia/include/gpu/ganesh/SkSurfaceGanesh.h"
17-
#include "third_party/skia/include/gpu/ganesh/gl/GrGLBackendSurface.h"
18-
#include "third_party/skia/include/gpu/ganesh/gl/GrGLTypes.h"
19-
#include "third_party/skia/include/gpu/ganesh/vk/GrVkTypes.h"
2017

2118
#include <cstdlib>
2219
#include <memory>
2320
#include <utility>
2421

2522
#ifdef SHELL_ENABLE_VULKAN
2623
#include "third_party/skia/include/gpu/ganesh/vk/GrVkBackendSurface.h"
24+
#include "third_party/skia/include/gpu/ganesh/vk/GrVkTypes.h"
2725
#endif // SHELL_ENABLE_VULKAN
2826

2927
#ifdef SHELL_ENABLE_METAL
@@ -33,6 +31,8 @@
3331

3432
#ifdef SHELL_ENABLE_GL
3533
#include "flutter/testing/test_gl_surface.h"
34+
#include "third_party/skia/include/gpu/ganesh/gl/GrGLBackendSurface.h"
35+
#include "third_party/skia/include/gpu/ganesh/gl/GrGLTypes.h"
3636
#endif // SHELL_ENABLE_GL
3737

3838
// TODO(zanderso): https://github.com/flutter/flutter/issues/127701

0 commit comments

Comments
 (0)