Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 595f851

Browse files
author
nturgut
committed
more comments and linking the issue
1 parent cfc3e35 commit 595f851

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

lib/web_ui/dev/safari.dart

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,16 @@ class Safari extends Browser {
4141
// to open Safari for a given URL. In summary they provide a new instance
4242
// to open, that instance to wait for opening the url until Safari launches,
4343
// provide Safari bundles identifier.
44-
// For more details run `man open` on MacOS.
45-
// TODO(nurhan): explore implementing this part using Apple Script or
46-
// MacOS native APIs such as LSLaunchURLSpec. In the current solution there is
47-
// no way of closing Safari after opening with open command.
44+
// The details copied from `man open` on MacOS.
45+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50809
4846
var process = await Process.start(installation.executable, [
49-
'-F',
50-
'-W',
51-
'-n',
52-
'-b',
53-
'com.apple.Safari',
47+
'-F', // Open a fresh application with no persistant state.
48+
'-W', // Open to wait until the applications it opens.
49+
'-n', // Open a new instance of the application.
50+
'-b', // Specifies the bundle identifier for the application to use.
51+
'com.apple.Safari', // Bundle identifier for Safari.
5452
'${url.toString()}'
55-
] /* args */);
53+
]);
5654

5755
return process;
5856
});

0 commit comments

Comments
 (0)