Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 6dbeb10

Browse files
authored
[Impeller] Enable CanRenderInstance and CanCreateCPUBackedTexture on Vulkan. (#40722)
[Impeller] Enable CanRenderInstance and CanCreateCPUBackedTexture on Vulkan.
1 parent 0233a5a commit 6dbeb10

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

impeller/renderer/renderer_unittests.cc

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -379,10 +379,9 @@ TEST_P(RendererTest, CanRenderToTexture) {
379379
ASSERT_TRUE(r2t_pass->EncodeCommands());
380380
}
381381

382-
#if IMPELLER_ENABLE_METAL
383382
TEST_P(RendererTest, CanRenderInstanced) {
384-
if (GetParam() != PlaygroundBackend::kMetal) {
385-
GTEST_SKIP_("Instancing is only supported on Metal.");
383+
if (GetParam() == PlaygroundBackend::kOpenGLES) {
384+
GTEST_SKIP_("Instancing is not supported on OpenGL.");
386385
}
387386
using VS = InstancedDrawVertexShader;
388387
using FS = InstancedDrawFragmentShader;
@@ -444,7 +443,6 @@ TEST_P(RendererTest, CanRenderInstanced) {
444443
return true;
445444
}));
446445
}
447-
#endif // IMPELLER_ENABLE_METAL
448446

449447
TEST_P(RendererTest, CanBlitTextureToTexture) {
450448
auto context = GetContext();
@@ -967,8 +965,8 @@ TEST_P(RendererTest, InactiveUniforms) {
967965
}
968966

969967
TEST_P(RendererTest, CanCreateCPUBackedTexture) {
970-
if (GetParam() != PlaygroundBackend::kMetal) {
971-
GTEST_SKIP_("CPU backed textures only supported on Metal right now.");
968+
if (GetParam() == PlaygroundBackend::kOpenGLES) {
969+
GTEST_SKIP_("CPU backed textures are not supported on OpenGLES.");
972970
}
973971

974972
auto context = GetContext();

0 commit comments

Comments
 (0)