Add test for issue 28821

[email protected]

Review-Url: https://codereview.chromium.org/2707263005 .

Author: bwilkerson

pkg/analyzer/test/generated/strong_mode_driver_test.dart

@@ -56,6 +56,12 @@ class StrongModeStaticTypeAnalyzer2Test_Driver
     return super.test_genericMethod_functionInvocation_inferred();
   }
 
+  @failingTest
+  @override
+  test_genericMethod_override_covariant_field() async {
+    return super.test_genericMethod_override_covariant_field();
+  }
+
   @failingTest
   @override
   test_genericMethod_tearoff() {

pkg/analyzer/test/generated/strong_mode_test.dart

@@ -1172,22 +1172,22 @@ class StrongModeLocalInferenceTest extends ResolverTestCase {
     _isFutureOf([_isObject])(invoke.staticType);
   }
 
-  test_futureOrNull_no_return_value() async {
+  test_futureOrNull_no_return() async {
     MethodInvocation invoke = await _testFutureOr(r'''
     FutureOr<T> mk<T>(Future<T> x) => x;
     Future<int> f;
-    test() => f.then<Null>((int x) {return;});
+    test() => f.then<Null>((int x) {});
     ''');
     _isFunction2Of(_isInt, _isNull)(
         invoke.argumentList.arguments[0].staticType);
     _isFutureOfNull(invoke.staticType);
   }
 
-  test_futureOrNull_no_return() async {
+  test_futureOrNull_no_return_value() async {
     MethodInvocation invoke = await _testFutureOr(r'''
     FutureOr<T> mk<T>(Future<T> x) => x;
     Future<int> f;
-    test() => f.then<Null>((int x) {});
+    test() => f.then<Null>((int x) {return;});
     ''');
     _isFunction2Of(_isInt, _isNull)(
         invoke.argumentList.arguments[0].staticType);
@@ -2661,6 +2661,22 @@ class D extends C {
 ''');
   }
 
+  test_genericMethod_override_covariant_field() async {
+    Source source = addSource(r'''
+abstract class A {
+  num get x;
+  set x(covariant num);
+}
+
+class B extends A {
+  int x;
+}
+''');
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
   test_genericMethod_override_invalidReturnType() async {
     Source source = addSource(r'''
 class C {