Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 7a18ad2

Browse files
committed
Fix isolate_configuration typo
1 parent b991af9 commit 7a18ad2

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

runtime/dart_isolate.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ std::weak_ptr<DartIsolate> DartIsolate::SpawnIsolate(
9393
const fml::closure& isolate_shutdown_callback,
9494
std::optional<std::string> dart_entrypoint,
9595
std::optional<std::string> dart_entrypoint_library,
96-
std::unique_ptr<IsolateConfiguration> isolate_configration) const {
96+
std::unique_ptr<IsolateConfiguration> isolate_configuration) const {
9797
return CreateRunningRootIsolate(
9898
settings, //
9999
GetIsolateGroupData().GetIsolateSnapshot(), //
@@ -104,7 +104,7 @@ std::weak_ptr<DartIsolate> DartIsolate::SpawnIsolate(
104104
isolate_shutdown_callback, //
105105
dart_entrypoint, //
106106
dart_entrypoint_library, //
107-
std::move(isolate_configration), //
107+
std::move(isolate_configuration), //
108108
UIDartState::Context{GetTaskRunners(), //
109109
snapshot_delegate, //
110110
GetIOManager(), //
@@ -128,21 +128,21 @@ std::weak_ptr<DartIsolate> DartIsolate::CreateRunningRootIsolate(
128128
const fml::closure& isolate_shutdown_callback,
129129
std::optional<std::string> dart_entrypoint,
130130
std::optional<std::string> dart_entrypoint_library,
131-
std::unique_ptr<IsolateConfiguration> isolate_configration,
131+
std::unique_ptr<IsolateConfiguration> isolate_configuration,
132132
const UIDartState::Context& context,
133133
const DartIsolate* spawning_isolate) {
134134
if (!isolate_snapshot) {
135135
FML_LOG(ERROR) << "Invalid isolate snapshot.";
136136
return {};
137137
}
138138

139-
if (!isolate_configration) {
139+
if (!isolate_configuration) {
140140
FML_LOG(ERROR) << "Invalid isolate configuration.";
141141
return {};
142142
}
143143

144144
isolate_flags.SetNullSafetyEnabled(
145-
isolate_configration->IsNullSafetyEnabled(*isolate_snapshot));
145+
isolate_configuration->IsNullSafetyEnabled(*isolate_snapshot));
146146
isolate_flags.SetIsDontNeedSafe(isolate_snapshot->IsDontNeedSafe());
147147

148148
auto isolate = CreateRootIsolate(settings, //
@@ -173,7 +173,7 @@ std::weak_ptr<DartIsolate> DartIsolate::CreateRunningRootIsolate(
173173
return {};
174174
}
175175

176-
if (!isolate_configration->PrepareIsolate(*isolate.get())) {
176+
if (!isolate_configuration->PrepareIsolate(*isolate.get())) {
177177
FML_LOG(ERROR) << "Could not prepare isolate.";
178178
return {};
179179
}

runtime/dart_isolate.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ class DartIsolate : public UIDartState {
215215
const fml::closure& isolate_shutdown_callback,
216216
std::optional<std::string> dart_entrypoint,
217217
std::optional<std::string> dart_entrypoint_library,
218-
std::unique_ptr<IsolateConfiguration> isolate_configration,
218+
std::unique_ptr<IsolateConfiguration> isolate_configuration,
219219
const UIDartState::Context& context,
220220
const DartIsolate* spawning_isolate = nullptr);
221221

@@ -245,7 +245,7 @@ class DartIsolate : public UIDartState {
245245
const fml::closure& isolate_shutdown_callback,
246246
std::optional<std::string> dart_entrypoint,
247247
std::optional<std::string> dart_entrypoint_library,
248-
std::unique_ptr<IsolateConfiguration> isolate_configration) const;
248+
std::unique_ptr<IsolateConfiguration> isolate_configuration) const;
249249

250250
// |UIDartState|
251251
~DartIsolate() override;

runtime/dart_isolate_unittests.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ TEST_F(DartIsolateTest, SpawnIsolate) {
123123
/*isolate_shutdown_callback=*/settings.isolate_shutdown_callback,
124124
/*dart_entrypoint=*/"main",
125125
/*dart_entrypoint_library=*/std::nullopt,
126-
/*isolate_configration=*/std::move(spawn_configuration));
126+
/*isolate_configuration=*/std::move(spawn_configuration));
127127
auto spawn = weak_spawn.lock();
128128
ASSERT_TRUE(spawn);
129129
ASSERT_EQ(spawn->GetPhase(), DartIsolate::Phase::Running);

0 commit comments

Comments
 (0)