Make flow/... compatible with .clang_tidy. (#48148)

Author: matanlurey

flow/diff_context.cc

@@ -47,13 +47,7 @@ void DiffContext::EndSubtree() {
   state_stack_.pop_back();
 }
 
-DiffContext::State::State()
-    : dirty(false),
-      rect_index(0),
-      integral_transform(false),
-      clip_tracker_save_count(0),
-      has_filter_bounds_adjustment(false),
-      has_texture(false) {}
+DiffContext::State::State() {}
 
 void DiffContext::PushTransform(const SkMatrix& transform) {
   clip_tracker_.transform(transform);

flow/diff_context.h

@@ -208,9 +208,9 @@ class DiffContext {
   struct State {
     State();
 
-    bool dirty;
+    bool dirty = false;
 
-    size_t rect_index;
+    size_t rect_index = 0;
 
     // In order to replicate paint process closely, DiffContext needs to take
     // into account that some layers are painted with transform translation
@@ -221,17 +221,17 @@ class DiffContext {
     // during paint. This means the integral coordinates must be applied after
     // culling before painting the layer content (either the layer itself, or
     // when starting subtree to paint layer children).
-    bool integral_transform;
+    bool integral_transform = false;
 
     // Used to restoring clip tracker when popping state.
-    int clip_tracker_save_count;
+    int clip_tracker_save_count = 0;
 
     // Whether this subtree has filter bounds adjustment function. If so,
     // it will need to be removed from stack when subtree is closed.
-    bool has_filter_bounds_adjustment;
+    bool has_filter_bounds_adjustment = false;
 
     // Whether there is a texture layer in this subtree.
-    bool has_texture;
+    bool has_texture = false;
   };
 
   void MakeCurrentTransformIntegral();

flow/layers/layer.cc

@@ -11,8 +11,7 @@ namespace flutter {
 Layer::Layer()
     : paint_bounds_(SkRect::MakeEmpty()),
       unique_id_(NextUniqueID()),
-      original_layer_id_(unique_id_),
-      subtree_has_platform_view_(false) {}
+      original_layer_id_(unique_id_) {}
 
 Layer::~Layer() = default;
 

flow/layers/layer.h

@@ -266,7 +266,7 @@ class Layer {
   SkRect paint_bounds_;
   uint64_t unique_id_;
   uint64_t original_layer_id_;
-  bool subtree_has_platform_view_;
+  bool subtree_has_platform_view_ = false;
 
   static uint64_t NextUniqueID();
 

flow/layers/opacity_layer.cc

@@ -15,8 +15,7 @@ namespace flutter {
 OpacityLayer::OpacityLayer(SkAlpha alpha, const SkPoint& offset)
     : CacheableContainerLayer(std::numeric_limits<int>::max(), true),
       alpha_(alpha),
-      offset_(offset),
-      children_can_accept_opacity_(false) {}
+      offset_(offset) {}
 
 void OpacityLayer::Diff(DiffContext* context, const Layer* old_layer) {
   DiffContext::AutoSubtreeRestore subtree(context);

flow/layers/opacity_layer.h

@@ -50,7 +50,7 @@ class OpacityLayer : public CacheableContainerLayer {
  private:
   SkAlpha alpha_;
   SkPoint offset_;
-  bool children_can_accept_opacity_;
+  bool children_can_accept_opacity_ = false;
 
   FML_DISALLOW_COPY_AND_ASSIGN(OpacityLayer);
 };

flow/raster_cache.cc

@@ -71,8 +71,7 @@ void RasterCacheResult::draw(DlCanvas& canvas,
 RasterCache::RasterCache(size_t access_threshold,
                          size_t display_list_cache_limit_per_frame)
     : access_threshold_(access_threshold),
-      display_list_cache_limit_per_frame_(display_list_cache_limit_per_frame),
-      checkerboard_images_(false) {}
+      display_list_cache_limit_per_frame_(display_list_cache_limit_per_frame) {}
 
 /// @note Procedure doesn't copy all closures.
 std::unique_ptr<RasterCacheResult> RasterCache::Rasterize(

flow/raster_cache.h

@@ -264,7 +264,7 @@ class RasterCache {
   RasterCacheMetrics layer_metrics_;
   RasterCacheMetrics picture_metrics_;
   mutable RasterCacheKey::Map<Entry> cache_;
-  bool checkerboard_images_;
+  bool checkerboard_images_ = false;
 
   void TraceStatsToTimeline() const;
 

flow/raster_cache_item.h

@@ -7,6 +7,7 @@
 
 #include <memory>
 #include <optional>
+#include <utility>
 
 #include "flutter/display_list/dl_canvas.h"
 #include "flutter/flow/raster_cache_key.h"
@@ -31,7 +32,7 @@ class RasterCacheItem {
   explicit RasterCacheItem(RasterCacheKeyID key_id,
                            CacheState cache_state = CacheState::kNone,
                            unsigned child_entries = 0)
-      : key_id_(key_id),
+      : key_id_(std::move(key_id)),
         cache_state_(cache_state),
         child_items_(child_entries) {}
 

flow/skia_gpu_object.h

@@ -121,7 +121,7 @@ class UnrefQueue : public fml::RefCountedThreadSafe<UnrefQueue<T>> {
     }
 
     if (context) {
-      for (GrBackendTexture texture : textures) {
+      for (const GrBackendTexture& texture : textures) {
         context->deleteBackendTexture(texture);
       }