Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9080aa8

Browse files
authored
[cp] Removed clamping from dithering (#56140) (#56174)
tests: flutter/flutter#157643 fixes revert from flutter/flutter#153976 The pixel format will clamp if it needs to anyway so this isn't necessary. https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 77db576 commit 9080aa8

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

impeller/compiler/shader_lib/impeller/dithering.glsl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ vec4 IPOrderedDither8x8(vec4 color, vec2 dest) {
4545
// Apply the dither to the color.
4646
color.rgb += dither * kDitherRate;
4747

48-
// Clamp the color values to [0,1].
49-
color.rgb = clamp(color.rgb, 0.0, 1.0);
50-
5148
return color;
5249
}
5350

impeller/tools/malioc.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@
586586
"shortest_path_cycles": [
587587
0.5,
588588
0.109375,
589-
0.296875,
589+
0.28125,
590590
0.5,
591591
0.0,
592592
0.25,
@@ -596,9 +596,9 @@
596596
"load_store"
597597
],
598598
"total_cycles": [
599-
1.4249999523162842,
599+
1.40625,
600600
0.862500011920929,
601-
1.4249999523162842,
601+
1.40625,
602602
0.875,
603603
4.0,
604604
0.25,
@@ -636,7 +636,7 @@
636636
"longest_path_cycles": [
637637
0.5,
638638
0.109375,
639-
0.125,
639+
0.109375,
640640
0.5,
641641
0.0,
642642
0.25,
@@ -658,7 +658,7 @@
658658
"shortest_path_cycles": [
659659
0.5,
660660
0.109375,
661-
0.125,
661+
0.109375,
662662
0.5,
663663
0.0,
664664
0.25,
@@ -671,7 +671,7 @@
671671
"total_cycles": [
672672
0.5,
673673
0.109375,
674-
0.125,
674+
0.109375,
675675
0.5,
676676
0.0,
677677
0.25,
@@ -6298,7 +6298,7 @@
62986298
"shortest_path_cycles": [
62996299
0.5625,
63006300
0.203125,
6301-
0.265625,
6301+
0.25,
63026302
0.5625,
63036303
0.0,
63046304
0.25,
@@ -6308,9 +6308,9 @@
63086308
"load_store"
63096309
],
63106310
"total_cycles": [
6311-
0.71875,
6311+
0.699999988079071,
63126312
0.40625,
6313-
0.71875,
6313+
0.699999988079071,
63146314
0.5625,
63156315
4.0,
63166316
0.25,
@@ -6768,7 +6768,7 @@
67686768
"shortest_path_cycles": [
67696769
0.5625,
67706770
0.21875,
6771-
0.28125,
6771+
0.265625,
67726772
0.5625,
67736773
0.0,
67746774
0.25,
@@ -6778,9 +6778,9 @@
67786778
"load_store"
67796779
],
67806780
"total_cycles": [
6781-
0.71875,
6781+
0.699999988079071,
67826782
0.421875,
6783-
0.71875,
6783+
0.699999988079071,
67846784
0.625,
67856785
4.0,
67866786
0.25,

0 commit comments

Comments
 (0)