remove synthesize and use _container directly

Chris Yang · Chris Yang · commit 97e54266f417 · 2023-11-15T15:01:25.000-08:00
diff --git a/fml/platform/darwin/weak_nsobject.mm b/fml/platform/darwin/weak_nsobject.mm
@@ -29,8 +29,6 @@ - (id)initWithContainer:(fml::RefPtr<fml::WeakContainer>)container;
 
 @implementation CRBWeakNSProtocolSentinel
 
-@synthesize container = container_;
-
 + (fml::RefPtr<fml::WeakContainer>)containerForObject:(id)object
                                         threadChecker:(debug::DebugThreadChecker)checker {
   if (object == nil) {
@@ -53,10 +51,10 @@ @implementation CRBWeakNSProtocolSentinel
 }
 
 - (id)initWithContainer:(fml::RefPtr<fml::WeakContainer>)container {
-  FML_DCHECK(container.get());
+  FML_DCHECK(_container.get());
   self = [super init];
   if (self) {
-    container_ = container;
+    _container = container;
   }
   return self;
 }

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,6 @@ - (id)initWithContainer:(fml::RefPtr<fml::WeakContainer>)container;`
`29`	`29`
`30`	`30`	`@implementation CRBWeakNSProtocolSentinel`
`31`	`31`
`32`		`-@synthesize container = container_;`
`33`		`-`
`34`	`32`	`+ (fml::RefPtr<fml::WeakContainer>)containerForObject:(id)object`
`35`	`33`	`threadChecker:(debug::DebugThreadChecker)checker {`
`36`	`34`	`if (object == nil) {`
`@@ -53,10 +51,10 @@ @implementation CRBWeakNSProtocolSentinel`
`53`	`51`	`}`
`54`	`52`
`55`	`53`	`- (id)initWithContainer:(fml::RefPtr<fml::WeakContainer>)container {`
`56`		`- FML_DCHECK(container.get());`
	`54`	`+ FML_DCHECK(_container.get());`
`57`	`55`	`self = [super init];`
`58`	`56`	`if (self) {`
`59`		`- container_ = container;`
	`57`	`+ _container = container;`
`60`	`58`	`}`
`61`	`59`	`return self;`
`62`	`60`	`}`