Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9fb55ef

Browse files
authored
Revert "Test running the macOS engine has no stray logging" (#54778)
This reverts commit 5aed693. Revert #54716. This new check is flaking and isn't very high-value. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738562907128595441/+/u/test:_Host_Tests_for_host_profile/stdout [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent e708809 commit 9fb55ef

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ @implementation MockableFlutterEngine
210210

211211
// Replace stdout stream buffer with our own.
212212
StreamCapture stdout_capture(&std::cout);
213-
StreamCapture stderr_capture(&std::cerr);
214213

215214
// Launch the test entrypoint.
216215
FlutterEngine* engine = GetFlutterEngine();
@@ -220,12 +219,9 @@ @implementation MockableFlutterEngine
220219
latch.Wait();
221220

222221
stdout_capture.Stop();
223-
stderr_capture.Stop();
224222

225223
// Verify hello world was written to stdout.
226-
// Check equality to ensure no unexpected stray logging.
227-
EXPECT_EQ(stdout_capture.GetOutput(), "flutter: Hello logging\n");
228-
EXPECT_TRUE(stderr_capture.GetOutput().empty());
224+
EXPECT_TRUE(stdout_capture.GetOutput().find("Hello logging") != std::string::npos);
229225
}
230226

231227
TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) {

0 commit comments

Comments
 (0)