Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a72edab

Browse files
committed
Add tests
1 parent ef217c6 commit a72edab

File tree

4 files changed

+18
-3
lines changed

4 files changed

+18
-3
lines changed

lib/ui/compositing/scene.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Scene::Scene(std::shared_ptr<flutter::Layer> rootLayer,
4444
bool checkerboardOffscreenLayers) {
4545
auto viewport_metrics = UIDartState::Current()
4646
->platform_configuration()
47-
->get_window()
47+
->window()
4848
.viewport_metrics();
4949

5050
layer_tree_ = std::make_unique<LayerTree>(

lib/ui/painting/canvas.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ void Canvas::drawShadow(const CanvasPath* path,
428428
}
429429
SkScalar dpr = UIDartState::Current()
430430
->platform_configuration()
431-
->get_window()
431+
->window()
432432
.viewport_metrics()
433433
.device_pixel_ratio;
434434
external_allocation_size_ += path->path().approximateBytesUsed();

lib/ui/window/platform_configuration.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ class PlatformConfiguration final {
100100
/// @brief Retrieves the Window.
101101
///
102102
/// @return the Window.
103-
const Window& get_window() const { return *window_; }
103+
const Window& window() const { return *window_; }
104104

105105
//----------------------------------------------------------------------------
106106
/// @brief Sets the viewport metrics of the Window.

lib/ui/window/platform_configuration_unittests.cc

+15
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,21 @@ class DummyPlatformConfigurationClient : public PlatformConfigurationClient {
5151
TEST(PlatformConfigurationTest, PlatformConfigurationInitialization) {
5252
DummyPlatformConfigurationClient client;
5353
PlatformConfiguration configuration(&client);
54+
55+
ASSERT_EQ(configuration.client(), &client);
56+
ASSERT_EQ(configuration.window().viewport_metrics().device_pixel_ratio, 1.0);
57+
ASSERT_EQ(configuration.window().viewport_metrics().physical_width, 0.0);
58+
ASSERT_EQ(configuration.window().viewport_metrics().physical_height, 0.0);
59+
}
60+
61+
TEST(PlatformConfigurationTest, PlatformConfigurationWindowMetricsUpdate) {
62+
DummyPlatformConfigurationClient client;
63+
PlatformConfiguration configuration(&client);
64+
65+
configuration.SetWindowMetrics({2.0, 10.0, 20.0});
66+
ASSERT_EQ(configuration.window().viewport_metrics().device_pixel_ratio, 2.0);
67+
ASSERT_EQ(configuration.window().viewport_metrics().physical_width, 10.0);
68+
ASSERT_EQ(configuration.window().viewport_metrics().physical_height, 20.0);
5469
}
5570

5671
} // namespace testing

0 commit comments

Comments
 (0)