cleanup

Author: mdebbar

lib/web_ui/lib/src/engine/text/canvas_paragraph.dart

@@ -157,35 +157,15 @@ class CanvasParagraph implements ui.Paragraph {
     cssStyle
       ..position = 'absolute'
       // Prevent the browser from doing any line breaks in the paragraph. We want
-      // to insert our own <BR> breaks based on layout results.
+      // to have full control of the paragraph layout.
       ..whiteSpace = 'pre';
 
-    // if (width > longestLine) {
-      // In this case, we set the width so that the CSS text-align property
-      // works correctly.
-      // When `longestLine` is >= `paragraph.width` that means the DOM element
-      // will automatically size itself to fit the longest line, so there's no
-      // need to set an explicit width.
-      cssStyle.width = '${width}px';
-    // }
-
-    // if (paragraphStyle.maxLines != null || paragraphStyle.ellipsis != null) {
-    //   cssStyle
-    //     ..overflow = 'hidden'
-    //     ..height = '${height}px';
-    // }
-
     // 2. Append all spans to the paragraph.
 
     html.HtmlElement? lastSpanElement;
     final List<EngineLineMetrics> lines = computeLineMetrics();
 
     for (int i = 0; i < lines.length; i++) {
-      // Insert a <BR> element before each line except the first line.
-      if (i > 0) {
-        rootElement.append(html.document.createElement('br'));
-      }
-
       final EngineLineMetrics line = lines[i];
       final List<RangeBox> boxes = line.boxes;
       final StringBuffer buffer = StringBuffer();

lib/web_ui/test/html/paragraph/general_golden_test.dart

@@ -371,7 +371,7 @@ Future<void> testMain() async {
   });
 
   void testFontFeatures(EngineCanvas canvas) {
-    const String text = 'Aa Bb Dd Ee Ff Difficult';
+    const String text = 'Bb Difficult ';
     const FontFeature enableSmallCaps = FontFeature('smcp');
     const FontFeature disableSmallCaps = FontFeature('smcp', 0);
 
@@ -446,7 +446,7 @@ Future<void> testMain() async {
             enableOnum,
           ],
         ));
-        builder.addText('$text - $numeric');
+        builder.addText('$text  $numeric');
         builder.pop(); // enableSmallCaps, enableOnum
       },
     )..layout(constrain(double.infinity));