Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e1ccac7

Browse files
y-novikovCommit Bot
authored andcommitted
Don't print INFO level log messages in Release by default.
Even with dcheck_always_on. INFO level log messages will still be printed in Debug or when angle_enable_trace is enabled. Bug: angleproject:3525 Change-Id: Ic3807f94307af2878aee78426c969ab846ae3881 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050890 Reviewed-by: Jamie Madill <[email protected]> Reviewed-by: Courtney Goeltzenleuchter <[email protected]> Commit-Queue: Yuly Novikov <[email protected]>
1 parent 3b82506 commit e1ccac7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/common/debug.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ bool ShouldCreateLogMessage(LogSeverity severity)
5454
#if defined(ANGLE_TRACE_ENABLED)
5555
return true;
5656
#elif defined(ANGLE_ENABLE_ASSERTS)
57-
return severity != LOG_EVENT;
57+
return severity == LOG_FATAL || severity == LOG_ERR || severity == LOG_WARN;
5858
#else
5959
return false;
6060
#endif
@@ -254,7 +254,8 @@ void Trace(LogSeverity severity, const char *message)
254254
default:
255255
UNREACHABLE();
256256
}
257-
os_log_with_type(OS_LOG_DEFAULT, apple_log_type, "ANGLE: %s: %s\n", LogSeverityName(severity), str.c_str());
257+
os_log_with_type(OS_LOG_DEFAULT, apple_log_type, "ANGLE: %s: %s\n",
258+
LogSeverityName(severity), str.c_str());
258259
}
259260
#else
260261
// Note: we use fprintf because <iostream> includes static initializers.

0 commit comments

Comments
 (0)