Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f3d7a76

Browse files
authored
Make scoped_nsprotocol::release() private. (#21467)
This is not used anywhere in the engine. However, this API is easy to misuse as one might incorrectly assume that it releases the reference on the underlying object. Callers must use `reset` for this purpose.
1 parent b133df3 commit f3d7a76

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

fml/platform/darwin/scoped_nsobject.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ class scoped_nsprotocol {
7676
object_ = temp;
7777
}
7878

79+
// Shift reference to the autorelease pool to be released later.
80+
NST autorelease() { return [release() autorelease]; }
81+
82+
private:
83+
NST object_;
84+
7985
// scoped_nsprotocol<>::release() is like scoped_ptr<>::release. It is NOT a
8086
// wrapper for [object_ release]. To force a scoped_nsprotocol<> to call
8187
// [object_ release], use scoped_nsprotocol<>::reset().
@@ -84,12 +90,6 @@ class scoped_nsprotocol {
8490
object_ = nil;
8591
return temp;
8692
}
87-
88-
// Shift reference to the autorelease pool to be released later.
89-
NST autorelease() { return [release() autorelease]; }
90-
91-
private:
92-
NST object_;
9393
};
9494

9595
// Free functions

0 commit comments

Comments
 (0)