test tweaks

Author: jonahwilliams

impeller/aiks/aiks_unittests.cc

@@ -2440,7 +2440,7 @@ TEST_P(AiksTest, OpacityPeepHoleApplicationTest) {
   Entity entity;
   entity.SetContents(SolidColorContents::Make(
       PathBuilder{}.AddRect(rect).TakePath(), Color::Red()));
-  entity_pass->AddEntity(entity);
+  entity_pass->AddEntity(std::move(entity));
   paint.color = Color::Red().WithAlpha(0.5);
 
   delegate = std::make_shared<OpacityPeepholePassDelegate>(paint);

impeller/aiks/canvas.cc

@@ -71,9 +71,10 @@ static std::shared_ptr<Contents> CreateContentsForGeometryWithFilters(
   return contents_copy;
 }
 
-static std::shared_ptr<Contents> CreateContentsWithFilters(const Paint& paint,
-                                                           const Path& path = {},
-                                                           bool cover = false) {
+static std::shared_ptr<Contents> CreateContentsWithFilters(
+    const Paint& paint,
+    const Path& path = {},
+    bool cover = false) {
   std::shared_ptr<Geometry> geometry;
   if (cover) {
     geometry = Geometry::MakeCover();

impeller/entity/entity_unittests.cc

@@ -103,7 +103,7 @@ auto CreatePassWithRectPath(Rect rect,
   Entity entity;
   entity.SetContents(SolidColorContents::Make(
       PathBuilder{}.AddRect(rect).TakePath(), Color::Red()));
-  subpass->AddEntity(entity);
+  subpass->AddEntity(std::move(entity));
   subpass->SetDelegate(std::make_unique<TestPassDelegate>(collapse));
   subpass->SetBoundsLimit(bounds_hint);
   return subpass;
@@ -152,7 +152,7 @@ TEST_P(EntityTest, EntityPassCanMergeSubpassIntoParent) {
   contents->SetColor(Color::Blue());
   entity.SetContents(std::move(contents));
 
-  pass.AddEntity(entity);
+  pass.AddEntity(std::move(entity));
 
   ASSERT_TRUE(OpenPlaygroundHere(pass));
 }
@@ -2465,7 +2465,7 @@ TEST_P(EntityTest, AdvancedBlendCoverageHintIsNotResetByEntityPass) {
       RenderTarget::kDefaultColorAttachmentConfig, stencil_config);
   auto content_context = ContentContext(
       GetContext(), TypographerContextSkia::Make(), test_allocator);
-  pass->AddEntity(entity);
+  pass->AddEntity(std::move(entity));
 
   EXPECT_TRUE(pass->Render(content_context, rt));