Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fe6061f

Browse files
committed
[vulkan][fuchsia] Disable second half of ShellTest.CacheSkSLWorks on
vulkan backend GrContext::precompileShader() is not implemented for vulkan contexts, so dont run the portion of this test that depends on that behavior on Vulkan.
1 parent 1a24307 commit fe6061f

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

shell/common/persistent_cache_unittests.cc

+5
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,17 @@ TEST_F(ShellTest, CacheSkSLWorks) {
9999
firstFrameLatch.Wait();
100100
WaitForIO(shell.get());
101101

102+
// Shader precompilation from SKSL is not implemented on the Skia Vulkan
103+
// backend so don't run the second half of this test on Vulkan. This can get
104+
// removed if SKSL precompilation is implemented in the Skia Vulkan backend.
105+
#if !defined(SHELL_ENABLE_VULKAN)
102106
// To check that all shaders are precompiled, verify that no new skp is dumped
103107
// due to shader compilations.
104108
int old_skp_count = skp_count;
105109
skp_count = 0;
106110
fml::VisitFilesRecursively(dir.fd(), skp_visitor);
107111
ASSERT_EQ(skp_count, old_skp_count);
112+
#endif // !defined(SHELL_ENABLE_VULKAN)
108113

109114
// Remove all files generated
110115
fml::FileVisitor remove_visitor = [&remove_visitor](

0 commit comments

Comments
 (0)