This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-land "Use ELF for Dart AOT snapshots on Fuchsia. #13896" #15360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingjun
approved these changes
Jan 9, 2020
| dart_utils::Check(path[0] != '/', LOG_TAG); | ||
|
|
||
| if (namespc == nullptr) { | ||
| if (!VmoFromFilename(path, resource_vmo)) { |
There was a problem hiding this comment.
Nit: Should this be dart_utils::VmoFromFilename for consistency?
There was a problem hiding this comment.
We're in the dart_utils namespace here, so I think the Google style guide allows (encourages?) using the unqualified name. At least, that's the convention we follow in Dart.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 11, 2020
flutter/engine@7ef88f8...3d37d39 git log 7ef88f8..3d37d39 --first-parent --oneline 2020-01-11 [email protected] Roll src/third_party/skia 67d0f3fd725c..3723fb7e85bb (25 commits) (flutter/engine#15466) 2020-01-10 [email protected] Re-land "Use ELF for Dart AOT snapshots on Fuchsia. #13896" (flutter/engine#15360) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…lutter#15360) The bug in the original CL was that we were not running replace_as_executable in OpenVmo if the namespace was not provided. This was a divergence in behavior for MappedResource::LoadFromNamespace compared to the current implementation.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…3896" (flutter#15360)" This reverts commit 949be9d.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…lutter#15360) The bug in the original CL was that we were not running replace_as_executable in OpenVmo if the namespace was not provided. This was a divergence in behavior for MappedResource::LoadFromNamespace compared to the current implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug in the original CL was that we were not running
replace_as_executableinOpenVmoif the namespace was not provided.This was a divergence in behavior for
MappedResource::LoadFromNamespacecompared to the current implementation.