From 9941b3af2d5f763210d1de5c987406fa3c34b554 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Tue, 7 Apr 2020 13:19:18 -0700 Subject: [PATCH] Remove SceneDisplayLag trace event temporarily Working theory is that adding async events with begin times in the past causes the timeline to skip some events. See: https://github.com/flutter/flutter/issues/54095 --- shell/common/rasterizer.cc | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/shell/common/rasterizer.cc b/shell/common/rasterizer.cc index f360cefe960f0..0a6a060c26382 100644 --- a/shell/common/rasterizer.cc +++ b/shell/common/rasterizer.cc @@ -242,7 +242,6 @@ RasterStatus Rasterizer::DoDraw( } FrameTiming timing; - const fml::TimePoint frame_target_time = layer_tree->target_time(); timing.Set(FrameTiming::kBuildStart, layer_tree->build_start()); timing.Set(FrameTiming::kBuildFinish, layer_tree->build_finish()); timing.Set(FrameTiming::kRasterStart, fml::TimePoint::Now()); @@ -272,32 +271,6 @@ RasterStatus Rasterizer::DoDraw( timing.Set(FrameTiming::kRasterFinish, raster_finish_time); delegate_.OnFrameRasterized(timing); - if (raster_finish_time > frame_target_time) { - fml::TimePoint latest_frame_target_time = - delegate_.GetLatestFrameTargetTime(); - const auto frame_budget_millis = delegate_.GetFrameBudget().count(); - if (latest_frame_target_time < raster_finish_time) { - latest_frame_target_time = - latest_frame_target_time + - fml::TimeDelta::FromMillisecondsF(frame_budget_millis); - } - const auto frame_lag = - (latest_frame_target_time - frame_target_time).ToMillisecondsF(); - const int vsync_transitions_missed = round(frame_lag / frame_budget_millis); - fml::tracing::TraceEventAsyncComplete( - "flutter", // category - "SceneDisplayLag", // name - frame_target_time, // begin_time - raster_finish_time, // end_time - "frame_target_time", // arg_key_1 - frame_target_time, // arg_val_1 - "current_frame_target_time", // arg_key_2 - latest_frame_target_time, // arg_val_2 - "vsync_transitions_missed", // arg_key_3 - vsync_transitions_missed // arg_val_3 - ); - } - // Pipeline pressure is applied from a couple of places: // rasterizer: When there are more items as of the time of Consume. // animator (via shell): Frame gets produces every vsync.