From 5f6a54641a6d4a6246f52950bfb56823c2942d6b Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Wed, 16 Mar 2022 14:29:45 -0400 Subject: [PATCH 1/2] [web] Remove the --passfail flag when calling goldctl in post-submit --- web_sdk/web_test_utils/lib/skia_client.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/web_sdk/web_test_utils/lib/skia_client.dart b/web_sdk/web_test_utils/lib/skia_client.dart index 13aeb7c16acda..8b948dfae52ec 100644 --- a/web_sdk/web_test_utils/lib/skia_client.dart +++ b/web_sdk/web_test_utils/lib/skia_client.dart @@ -132,7 +132,6 @@ class SkiaGoldClient { '--commit', commitHash, '--keys-file', keys.path, '--failure-file', failures.path, - '--passfail', ]; if (imgtestInitCommand.contains(null)) { From 2f1a8cc934d27cd29abd78684558113f7b9a1237 Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Wed, 16 Mar 2022 14:41:51 -0400 Subject: [PATCH 2/2] add comment --- web_sdk/web_test_utils/lib/skia_client.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/web_sdk/web_test_utils/lib/skia_client.dart b/web_sdk/web_test_utils/lib/skia_client.dart index 8b948dfae52ec..511141c5f8566 100644 --- a/web_sdk/web_test_utils/lib/skia_client.dart +++ b/web_sdk/web_test_utils/lib/skia_client.dart @@ -222,6 +222,9 @@ class SkiaGoldClient { '--commit', commitHash, '--keys-file', keys.path, '--failure-file', failures.path, + // This is running in pre-submit so it's okay for the `goldctl` commands + // to fail when the images don't match. But during post-submit + // (in `_imgtestInit`) we shouldn't let the command fail. '--passfail', '--crs', 'github', '--patchset_id', commitHash,