From 84c40ca058b5757e3eaa99ca6f4376e22e81719f Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Fri, 28 Jul 2023 17:13:13 -0700 Subject: [PATCH 1/3] [Impeller] Update documentation on RenderDoc frame capture. Fixes https://github.com/flutter/flutter/issues/131461 --- impeller/docs/renderdoc_frame_capture.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/impeller/docs/renderdoc_frame_capture.md b/impeller/docs/renderdoc_frame_capture.md index f6e9a030e1c9d..5af9aa5f4400a 100644 --- a/impeller/docs/renderdoc_frame_capture.md +++ b/impeller/docs/renderdoc_frame_capture.md @@ -1,6 +1,6 @@ # Frame Capture with RenderDoc -[RenderDoc](https://renderdoc.org/) is a graphics debugger that can be used to capture frames. With Impeller starting to support gles and Vulkan backends, RenderDoc can provide insights into the application's frames. +[RenderDoc](https://renderdoc.org/) is a graphics debugger that can be used to capture frames. With Impeller starting to support OpenGL-ES and Vulkan backends, RenderDoc can provide insights into the application's frames. 1. First step is to set up RenderDoc. Follow the instructions [here](https://renderdoc.org/docs/getting_started/quick_start.html). For the purposes of this guide it is assumed that you are able to get RenderDoc running. 2. The next step would be to run the application you wish the capture the frames of. Typically these would be one of the playground tests. To build these, do: @@ -8,9 +8,8 @@ ```bash # In your $ENGINE_SRC folder, do: -./flutter/tools/gn --unopt --no-lto --enable-impeller-playground\ - --target-dir host_debug_impeller_vulkan -autoninja -C out/host_debug_impeller_vulkan/ +./flutter/tools/gn --unopt --no-lto --enable-impeller-vulkan +autoninja -C out/host_debug_unopt/ ``` 3. Start RenderDoc, and click the "Launch Application" button. @@ -19,7 +18,7 @@ autoninja -C out/host_debug_impeller_vulkan/ 4. Fill out the following parameters, and click launch: - executable: `$ENGINE_SRC/out/host_debug_impeller_vulkan/impeller_unittests` (expand `ENGINE_SRC`). - - args: `--gtest_filter="*CanDrawRect/Vulkan*"` + - args: `--gtest_filter="*CanDrawRect/Vulkan*" --enable_playground` - working dir: `$ENGINE_SRC` (expand `ENGINE_SRC`) 5. For the frame you wish to capture, press `F12`, you will now be able to see the frame capture and inspect the state. From 2463364905eb21e134356a719c14e97f72602bfd Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Fri, 28 Jul 2023 17:25:41 -0700 Subject: [PATCH 2/3] Update renderdoc_frame_capture.md --- impeller/docs/renderdoc_frame_capture.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/impeller/docs/renderdoc_frame_capture.md b/impeller/docs/renderdoc_frame_capture.md index 5af9aa5f4400a..6e9a1af96604d 100644 --- a/impeller/docs/renderdoc_frame_capture.md +++ b/impeller/docs/renderdoc_frame_capture.md @@ -8,8 +8,8 @@ ```bash # In your $ENGINE_SRC folder, do: -./flutter/tools/gn --unopt --no-lto --enable-impeller-vulkan -autoninja -C out/host_debug_unopt/ +./flutter/tools/gn --unopt --enable-impeller-vulkan +ninja -C out/host_debug_unopt/ ``` 3. Start RenderDoc, and click the "Launch Application" button. From 2823e0ce3dd997f9306a543f145c2ffe04aa5d42 Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Fri, 28 Jul 2023 17:26:18 -0700 Subject: [PATCH 3/3] Update renderdoc_frame_capture.md --- impeller/docs/renderdoc_frame_capture.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impeller/docs/renderdoc_frame_capture.md b/impeller/docs/renderdoc_frame_capture.md index 6e9a1af96604d..322a3bf03ea9d 100644 --- a/impeller/docs/renderdoc_frame_capture.md +++ b/impeller/docs/renderdoc_frame_capture.md @@ -1,6 +1,6 @@ # Frame Capture with RenderDoc -[RenderDoc](https://renderdoc.org/) is a graphics debugger that can be used to capture frames. With Impeller starting to support OpenGL-ES and Vulkan backends, RenderDoc can provide insights into the application's frames. +[RenderDoc](https://renderdoc.org/) is a graphics debugger that can be used to capture frames. With Impeller starting to support OpenGL ES and Vulkan backends, RenderDoc can provide insights into the application's frames. 1. First step is to set up RenderDoc. Follow the instructions [here](https://renderdoc.org/docs/getting_started/quick_start.html). For the purposes of this guide it is assumed that you are able to get RenderDoc running. 2. The next step would be to run the application you wish the capture the frames of. Typically these would be one of the playground tests. To build these, do: