From b83e0aa7b619bd2a5533f3d8d5802e1a8d3a8b46 Mon Sep 17 00:00:00 2001
From: Zach Anderson <zra@google.com>
Date: Thu, 17 Aug 2023 08:47:09 -0700
Subject: [PATCH] Adds a linux_clang_tidy_presubmit builder

---
 .ci.yaml                                    |  40 +++++++
 ci/builders/linux_clang_tidy_presubmit.json |  95 ++++++++++++++++
 ci/builders/mac_clang_tidy_presubmit.json   | 114 ++++++++++++++++++++
 3 files changed, 249 insertions(+)
 create mode 100644 ci/builders/linux_clang_tidy_presubmit.json
 create mode 100644 ci/builders/mac_clang_tidy_presubmit.json

diff --git a/.ci.yaml b/.ci.yaml
index 99ba38a9fd054..848d449b22e1a 100644
--- a/.ci.yaml
+++ b/.ci.yaml
@@ -226,6 +226,25 @@ targets:
       - "**.frag"
       - "**.vert"
 
+  - name: Linux linux_clang_tidy_presubmit
+    bringup: true
+    recipe: engine_v2/engine_v2
+    timeout: 120
+    properties:
+      config_name: linux_clang_tidy_presubmit
+    runIf:
+      - DEPS
+      - .ci.yaml
+      - tools/clang_tidy/**
+      - ci/builders/**
+      - ci/clang_tidy.sh
+      - "**.h"
+      - "**.c"
+      - "**.cc"
+      - "**.fbs"
+      - "**.frag"
+      - "**.vert"
+
   - name: Linux linux_arm_host_engine
     recipe: engine_v2/engine_v2
     timeout: 120
@@ -360,6 +379,27 @@ targets:
       - "**.m"
       - "**.mm"
 
+  - name: Mac mac_clang_tidy_presubmit
+    bringup: true
+    recipe: engine_v2/engine_v2
+    timeout: 120
+    properties:
+      config_name: mac_clang_tidy_presubmit
+    runIf:
+      - DEPS
+      - .ci.yaml
+      - tools/clang_tidy/**
+      - ci/builders/**
+      - ci/clang_tidy.sh
+      - "**.h"
+      - "**.c"
+      - "**.cc"
+      - "**.fbs"
+      - "**.frag"
+      - "**.vert"
+      - "**.m"
+      - "**.mm"
+
   - name: Mac mac_host_engine
     recipe: engine_v2/engine_v2
     timeout: 120
diff --git a/ci/builders/linux_clang_tidy_presubmit.json b/ci/builders/linux_clang_tidy_presubmit.json
new file mode 100644
index 0000000000000..e3aaad01afdf3
--- /dev/null
+++ b/ci/builders/linux_clang_tidy_presubmit.json
@@ -0,0 +1,95 @@
+{
+    "builds": [
+        {
+            "name": "android_debug_arm64",
+            "archives": [],
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Linux"
+            ],
+            "gn": [
+                "--android",
+                "--android-cpu",
+                "arm64",
+                "--no-lto"
+            ],
+            "ninja": {
+                "config": "android_debug_arm64"
+            }
+        },
+        {
+            "name": "host_debug",
+            "archives": [],
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Linux"
+            ],
+            "gn": [
+                "--runtime-mode",
+                "debug",
+                "--prebuilt-dart-sdk",
+                "--no-lto"
+            ],
+            "ninja": {
+                "config": "host_debug"
+            }
+        }
+    ],
+    "tests": [
+        {
+            "name": "test: lint host_debug",
+            "recipe": "engine_v2/tester_engine",
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Linux",
+                "cores=32"
+            ],
+            "gclient_variables": {
+                "download_android_deps": false
+            },
+            "dependencies": [
+                "host_debug",
+                "android_debug_arm64"
+            ],
+            "tasks": [
+                {
+                    "name": "test: lint host_debug",
+                    "parameters": [
+                        "--variant",
+                        "host_debug",
+                        "--shard-id=0",
+                        "--shard-variants=android_debug_arm64"
+                    ],
+                    "max_attempts": 1,
+                    "script": "flutter/ci/clang_tidy.sh"
+                }
+            ]
+        },
+        {
+            "name": "test: lint android_debug_arm64",
+            "recipe": "engine_v2/tester_engine",
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Linux",
+                "cores=32"
+            ],
+            "dependencies": [
+                "host_debug",
+                "android_debug_arm64"
+            ],
+            "tasks": [
+                {
+                    "name": "test: lint android_debug_arm64",
+                    "parameters": [
+                        "--variant",
+                        "android_debug_arm64",
+                        "--shard-id=1",
+                        "--shard-variants=host_debug"
+                    ],
+                    "max_attempts": 1,
+                    "script": "flutter/ci/clang_tidy.sh"
+                }
+            ]
+        }
+    ]
+}
diff --git a/ci/builders/mac_clang_tidy_presubmit.json b/ci/builders/mac_clang_tidy_presubmit.json
new file mode 100644
index 0000000000000..321e0c648eecf
--- /dev/null
+++ b/ci/builders/mac_clang_tidy_presubmit.json
@@ -0,0 +1,114 @@
+{
+    "builds": [
+        {
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Mac-12",
+                "cpu=arm64"
+            ],
+            "gclient_variables": {
+                "download_android_deps": false
+            },
+            "gn": [
+                "--runtime-mode",
+                "debug",
+                "--prebuilt-dart-sdk",
+                "--no-lto",
+                "--force-mac-arm64"
+            ],
+            "name": "host_debug",
+            "ninja": {
+                "config": "host_debug"
+            }
+        },
+        {
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Mac-12",
+                "cpu=arm64"
+            ],
+            "gclient_variables": {
+                "download_android_deps": false
+            },
+            "gn": [
+                "--ios",
+                "--runtime-mode",
+                "debug",
+                "--simulator",
+                "--no-lto",
+                "--force-mac-arm64"
+            ],
+            "name": "ios_debug_sim",
+            "ninja": {
+                "config": "ios_debug_sim"
+            }
+        }
+    ],
+    "tests": [
+        {
+            "name": "test: lint host_debug",
+            "recipe": "engine_v2/tester_engine",
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Mac",
+                "cpu=arm64"
+            ],
+            "gclient_variables": {
+                "download_android_deps": false
+            },
+            "dependencies": [
+                "host_debug",
+                "ios_debug_sim"
+            ],
+            "contexts": [
+                "osx_sdk"
+            ],
+            "tasks": [
+                {
+                    "name": "test: lint host_debug",
+                    "parameters": [
+                        "--variant",
+                        "host_debug",
+                        "--shard-id=0",
+                        "--shard-variants=ios_debug_sim"
+                    ],
+                    "max_attempts": 1,
+                    "script": "flutter/ci/clang_tidy.sh"
+                }
+            ]
+        },
+        {
+            "name": "test: lint ios_debug_sim",
+            "recipe": "engine_v2/tester_engine",
+            "drone_dimensions": [
+                "device_type=none",
+                "os=Mac",
+                "cpu=arm64"
+            ],
+            "gclient_variables": {
+                "download_android_deps": false
+            },
+            "dependencies": [
+                "host_debug",
+                "ios_debug_sim"
+            ],
+            "contexts": [
+                "osx_sdk"
+            ],
+            "tasks": [
+                {
+                    "name": "test: lint ios_debug_sim",
+                    "parameters": [
+                        "--variant",
+                        "ios_debug_sim",
+                        "--lint-all",
+                        "--shard-id=1",
+                        "--shard-variants=host_debug"
+                    ],
+                    "max_attempts": 1,
+                    "script": "flutter/ci/clang_tidy.sh"
+                }
+            ]
+        }
+    ]
+}